diff options
| author | Tim Graham <timograham@gmail.com> | 2017-10-12 14:58:18 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-10-12 14:58:18 -0400 |
| commit | 0edff2107f9cdd89737d2d33d1a40362ecde894c (patch) | |
| tree | 5cdf07cafd102e914520af5951b6a00cac7213e5 | |
| parent | f90be0a83ef5aa333b19e259faab73ee117d5339 (diff) | |
Refs #28248 -- Clarified the precision of PASSWORD_RESET_TIMEOUT_DAYS.
| -rw-r--r-- | django/contrib/auth/tokens.py | 6 | ||||
| -rw-r--r-- | docs/ref/settings.txt | 6 |
2 files changed, 9 insertions, 3 deletions
diff --git a/django/contrib/auth/tokens.py b/django/contrib/auth/tokens.py index eefa00c330..2272cd2415 100644 --- a/django/contrib/auth/tokens.py +++ b/django/contrib/auth/tokens.py @@ -41,7 +41,11 @@ class PasswordResetTokenGenerator: if not constant_time_compare(self._make_token_with_timestamp(user, ts), token): return False - # Check the timestamp is within limit + # Check the timestamp is within limit. Timestamps are rounded to + # midnight (server time) providing a resolution of only 1 day. If a + # link is generated 5 minutes before midnight and used 6 minutes later, + # that counts as 1 day. Therefore, PASSWORD_RESET_TIMEOUT_DAYS = 1 means + # "at least 1 day, could be up to 2." if (self._num_days(self._today()) - ts) > settings.PASSWORD_RESET_TIMEOUT_DAYS: return False diff --git a/docs/ref/settings.txt b/docs/ref/settings.txt index e664be0189..3e171c8d3d 100644 --- a/docs/ref/settings.txt +++ b/docs/ref/settings.txt @@ -2807,8 +2807,10 @@ the URL in two places (``settings`` and URLconf). Default: ``3`` -The number of days a password reset link is valid for. Used by the -:mod:`django.contrib.auth` password reset mechanism. +The minimum number of days a password reset link is valid for. Depending on +when the link is generated, it will be valid for up to a day longer. + +Used by the :class:`~django.contrib.auth.views.PasswordResetConfirmView`. .. setting:: PASSWORD_HASHERS |