summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClaude Paroz <claude@2xlibre.net>2014-08-29 10:22:59 +0200
committerClaude Paroz <claude@2xlibre.net>2014-08-29 10:25:32 +0200
commit022fdb2ac4a795af0fb1808942b260e2dc3d404d (patch)
tree978c790a30617582e12aa2795cc21a184c3f5936
parentf201cfae12961c60d293201add0c09a4e3024533 (diff)
[1.7.x] Fixed #22786 -- Documented value_from_datadict caveat
Thanks blueyed for the report and Tim Graham for the review. Backport of 909015a51b from master.
-rw-r--r--docs/ref/forms/widgets.txt7
1 files changed, 6 insertions, 1 deletions
diff --git a/docs/ref/forms/widgets.txt b/docs/ref/forms/widgets.txt
index e5963397a2..45f5d83887 100644
--- a/docs/ref/forms/widgets.txt
+++ b/docs/ref/forms/widgets.txt
@@ -217,7 +217,12 @@ foundation for custom widgets.
.. method:: value_from_datadict(data, files, name)
Given a dictionary of data and this widget's name, returns the value
- of this widget. Returns ``None`` if a value wasn't provided.
+ of this widget. ``files`` may contain data coming from
+ :attr:`request.FILES <django.http.HttpRequest.FILES>`. Returns ``None``
+ if a value wasn't provided. Note also that ``value_from_datadict`` may
+ be called more than once during handling of form data, so if you
+ customize it and add expensive processing, you should implement some
+ caching mechanism yourself.
.. class:: MultiWidget(widgets, attrs=None)