From a245604277eb9edeba234dacf199890766462709 Mon Sep 17 00:00:00 2001 From: nessita <124304+nessita@users.noreply.github.com> Date: Tue, 1 Apr 2025 13:52:22 -0300 Subject: Fixed #36284, Refs #31170 -- Ensured related lookup popups are closed properly. In the admin, when selecting related objects via the helpers defined in `RelatedObjectLookups.js`, the `dismissRelatedLookupPopup` function was attempting to access `window.relatedWindows`, which does not exist in real execution, causing related lookup popups to remain open. This change ensures that this code correctly accesses the module-local `relatedWindows` by explicitly assigning it to `window.relatedWindows`. Regression in 91bebf1adb43561b54bac18e76224759dc70acb3. Thanks Matthias Kestenholz for the report, the fix ideas, and testing. Co-authored-by: Matthias Kestenholz --- js_tests/admin/RelatedObjectLookups.test.js | 1 - 1 file changed, 1 deletion(-) (limited to 'js_tests/admin/RelatedObjectLookups.test.js') diff --git a/js_tests/admin/RelatedObjectLookups.test.js b/js_tests/admin/RelatedObjectLookups.test.js index 722aa7ae7b..0d71d88f2a 100644 --- a/js_tests/admin/RelatedObjectLookups.test.js +++ b/js_tests/admin/RelatedObjectLookups.test.js @@ -8,7 +8,6 @@ QUnit.module('admin.RelatedObjectLookups', { `); - window.relatedWindows = window.relatedWindows || []; } }); -- cgit v1.3