From 0f843fdd5b9b2f2307148465cd60f4e1b2befbb4 Mon Sep 17 00:00:00 2001 From: Mariusz Felisiak Date: Sat, 4 Jan 2020 20:49:11 +0100 Subject: Fixed #31136 -- Disabled grouping by aliases on QuerySet.values()/values_list(). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Regression in fb3f034f1c63160c0ff13c609acd01c18be12f80. Thanks Sigurd Ljødal for the report. --- django/db/models/sql/query.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'django/db/models/sql/query.py') diff --git a/django/db/models/sql/query.py b/django/db/models/sql/query.py index fc423b6acf..f96a0a6e2d 100644 --- a/django/db/models/sql/query.py +++ b/django/db/models/sql/query.py @@ -2095,7 +2095,9 @@ class Query(BaseExpression): if self.group_by is True: self.add_fields((f.attname for f in self.model._meta.concrete_fields), False) - self.set_group_by() + # Disable GROUP BY aliases to avoid orphaning references to the + # SELECT clause which is about to be cleared. + self.set_group_by(allow_aliases=False) self.clear_select_fields() if fields: -- cgit v1.3