diff options
| author | darkryder <sambhav13085@iiitd.ac.in> | 2015-01-21 22:25:57 +0530 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2015-02-03 14:59:45 -0500 |
| commit | 9ec8aa5e5d42ac4529846f7eae6bf4982800abff (patch) | |
| tree | 6a1195ff3831031f8207e18e4dcf69015fb4c50c /tests | |
| parent | 570912a97d5051fa3aeacd9d16c3be9afcf92198 (diff) | |
Fixed #24149 -- Normalized tuple settings to lists.
Diffstat (limited to 'tests')
36 files changed, 174 insertions, 171 deletions
diff --git a/tests/admin_changelist/tests.py b/tests/admin_changelist/tests.py index 5ee5a512db..16b56aef86 100644 --- a/tests/admin_changelist/tests.py +++ b/tests/admin_changelist/tests.py @@ -664,7 +664,7 @@ class AdminLogNodeTestCase(TestCase): self.assertEqual(template.render(context), '') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_changelist.urls") class SeleniumFirefoxTests(AdminSeleniumWebDriverTestCase): diff --git a/tests/admin_custom_urls/tests.py b/tests/admin_custom_urls/tests.py index ea3c0704b3..56827c08c4 100644 --- a/tests/admin_custom_urls/tests.py +++ b/tests/admin_custom_urls/tests.py @@ -8,7 +8,7 @@ from django.test import TestCase, override_settings from .models import Action, Person, Car -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_custom_urls.urls',) class AdminCustomUrlsTest(TestCase): """ @@ -80,7 +80,7 @@ class AdminCustomUrlsTest(TestCase): self.assertContains(response, 'value="path/to/html/document.html"') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_custom_urls.urls',) class CustomRedirects(TestCase): fixtures = ['users.json', 'actions.json'] diff --git a/tests/admin_docs/tests.py b/tests/admin_docs/tests.py index 2b0f6dc065..5ba0e2a0bc 100644 --- a/tests/admin_docs/tests.py +++ b/tests/admin_docs/tests.py @@ -13,7 +13,7 @@ from .models import Person, Company @override_settings( - PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), + PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_docs.urls') @modify_settings(INSTALLED_APPS={'append': 'django.contrib.admindocs'}) class AdminDocsTestCase(TestCase): diff --git a/tests/admin_inlines/tests.py b/tests/admin_inlines/tests.py index ed931a0cc1..fe481994d0 100644 --- a/tests/admin_inlines/tests.py +++ b/tests/admin_inlines/tests.py @@ -21,7 +21,7 @@ from .models import (Holder, Inner, Holder2, Inner2, Holder3, Inner3, Person, INLINE_CHANGELINK_HTML = 'class="inlinechangelink">Change</a>' -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_inlines.urls") class TestInline(TestCase): fixtures = ['admin-views-users.xml'] @@ -346,7 +346,7 @@ class TestInline(TestCase): self.assertNotContains(response, INLINE_CHANGELINK_HTML) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_inlines.urls") class TestInlineMedia(TestCase): fixtures = ['admin-views-users.xml'] @@ -423,7 +423,7 @@ class TestInlineAdminForm(TestCase): self.assertEqual(iaf2.original_content_type_id, poll_ct.id) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_inlines.urls") class TestInlineProtectedOnDelete(TestCase): fixtures = ['admin-views-users.xml'] @@ -650,7 +650,7 @@ class TestInlinePermissions(TestCase): self.assertContains(response, 'id="id_inner2_set-0-DELETE"') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_inlines.urls") class SeleniumFirefoxTests(AdminSeleniumWebDriverTestCase): diff --git a/tests/admin_views/tests.py b/tests/admin_views/tests.py index 090546c474..de3861d551 100644 --- a/tests/admin_views/tests.py +++ b/tests/admin_views/tests.py @@ -62,7 +62,7 @@ ERROR_MESSAGE = "Please enter the correct username and password \ for a staff account. Note that both fields may be case-sensitive." -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls", USE_I18N=True, USE_L10N=False, LANGUAGE_CODE='en') class AdminViewBasicTestCase(TestCase): @@ -888,7 +888,7 @@ class AdminCustomTemplateTests(AdminViewBasicTestCase): self.assertTemplateUsed(response, 'custom_filter_template.html') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminViewFormUrlTest(TestCase): fixtures = ["admin-views-users.xml"] @@ -919,7 +919,7 @@ class AdminViewFormUrlTest(TestCase): self.assertContains(response, 'value="overridden_value"') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminJavaScriptTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -961,7 +961,7 @@ class AdminJavaScriptTest(TestCase): self.assertNotContains(response, 'inlines.min.js') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class SaveAsTests(TestCase): fixtures = ['admin-views-users.xml', 'admin-views-person.xml'] @@ -1074,7 +1074,7 @@ def get_perm(Model, perm): return Permission.objects.get(content_type=ct, codename=perm) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminViewPermissionsTest(TestCase): """Tests for Admin Views Permissions.""" @@ -1762,7 +1762,7 @@ class AdminViewPermissionsTest(TestCase): self.client.get('/test_admin/admin7/logout/') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminViewsNoUrlTest(TestCase): """Regression test for #17333""" @@ -1794,7 +1794,7 @@ class AdminViewsNoUrlTest(TestCase): @skipUnlessDBFeature('can_defer_constraint_checks') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminViewDeletedObjectsTest(TestCase): fixtures = ['admin-views-users.xml', 'deleted-objects.xml'] @@ -1909,7 +1909,7 @@ class AdminViewDeletedObjectsTest(TestCase): self.assertContains(response, should_contain) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class TestGenericRelations(TestCase): fixtures = ['admin-views-users.xml', 'deleted-objects.xml'] @@ -1924,7 +1924,7 @@ class TestGenericRelations(TestCase): self.assertContains(response, "%s</td>" % plot) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminViewStringPrimaryKeyTest(TestCase): fixtures = ['admin-views-users.xml', 'string-primary-key.xml'] @@ -2079,7 +2079,7 @@ class AdminViewStringPrimaryKeyTest(TestCase): ) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class SecureViewTests(TestCase): """ @@ -2099,7 +2099,7 @@ class SecureViewTests(TestCase): self.assertEqual(response.context[REDIRECT_FIELD_NAME], secure_url) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminViewUnicodeTest(TestCase): fixtures = ['admin-views-unicode.xml'] @@ -2151,7 +2151,7 @@ class AdminViewUnicodeTest(TestCase): self.assertRedirects(response, '/test_admin/admin/admin_views/book/') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminViewListEditable(TestCase): fixtures = ['admin-views-users.xml', 'admin-views-person.xml'] @@ -2525,7 +2525,7 @@ class AdminViewListEditable(TestCase): self.assertContains(response, '<th class="field-id"><a href="%s">%d</a></th>' % (link2, story2.id), 1) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminSearchTest(TestCase): fixtures = ['admin-views-users', 'multiple-child-classes', @@ -2609,7 +2609,7 @@ class AdminSearchTest(TestCase): html=True) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminInheritedInlinesTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -2694,7 +2694,7 @@ class AdminInheritedInlinesTest(TestCase): self.assertEqual(Persona.objects.all()[0].accounts.count(), 2) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminActionsTest(TestCase): fixtures = ['admin-views-users.xml', 'admin-views-actions.xml'] @@ -2963,7 +2963,7 @@ action)</option> self.assertEqual(response.template_name, 'admin/popup_response.html') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class TestCustomChangeList(TestCase): fixtures = ['admin-views-users.xml'] @@ -2989,7 +2989,7 @@ class TestCustomChangeList(TestCase): self.assertNotContains(response, 'First Gadget') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class TestInlineNotEditable(TestCase): fixtures = ['admin-views-users.xml'] @@ -3006,7 +3006,7 @@ class TestInlineNotEditable(TestCase): self.assertEqual(response.status_code, 200) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminCustomQuerysetTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -3251,7 +3251,7 @@ class AdminCustomQuerysetTest(TestCase): self.assertEqual(self.client.get('/test_admin/admin/admin_views/filteredmanager/2/history/').status_code, 200) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminInlineFileUploadTest(TestCase): fixtures = ['admin-views-users.xml', 'admin-views-actions.xml'] @@ -3295,7 +3295,7 @@ class AdminInlineFileUploadTest(TestCase): self.assertContains(response, b"Currently") -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminInlineTests(TestCase): fixtures = ['admin-views-users.xml'] @@ -3611,7 +3611,7 @@ class AdminInlineTests(TestCase): self.assertEqual(Category.objects.get(id=4).order, 0) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class NeverCacheTests(TestCase): fixtures = ['admin-views-users.xml', 'admin-views-colors.xml', 'admin-views-fabrics.xml'] @@ -3682,7 +3682,7 @@ class NeverCacheTests(TestCase): self.assertEqual(get_max_age(response), None) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class PrePopulatedTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -3715,7 +3715,7 @@ class PrePopulatedTest(TestCase): self.assertContains(response, "maxLength: 1000") # instead of 1,000 -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class SeleniumAdminViewsFirefoxTests(AdminSeleniumWebDriverTestCase): @@ -3944,7 +3944,7 @@ class SeleniumAdminViewsIETests(SeleniumAdminViewsFirefoxTests): webdriver_class = 'selenium.webdriver.ie.webdriver.WebDriver' -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class ReadonlyTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -4052,7 +4052,7 @@ class ReadonlyTest(TestCase): self.assertNotContains(response, "Some help text for the date (with unicode ŠĐĆŽćžšđ)") -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class LimitChoicesToInAdminTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -4076,7 +4076,7 @@ class LimitChoicesToInAdminTest(TestCase): self.assertNotContains(response, marley.username) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class RawIdFieldsTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -4153,7 +4153,7 @@ class RawIdFieldsTest(TestCase): self.assertContains(response2, "Palin") -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class UserAdminTest(TestCase): """ @@ -4297,7 +4297,7 @@ class UserAdminTest(TestCase): self.assertEqual(response.context['form_url'], 'pony') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class GroupAdminTest(TestCase): """ @@ -4329,7 +4329,7 @@ class GroupAdminTest(TestCase): self.assertEqual(response.status_code, 200) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class CSSTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -4451,7 +4451,7 @@ except ImportError: @unittest.skipUnless(docutils, "no docutils installed.") -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") @modify_settings(INSTALLED_APPS={'append': ['django.contrib.admindocs', 'django.contrib.flatpages']}) class AdminDocsTest(TestCase): @@ -4493,7 +4493,7 @@ class AdminDocsTest(TestCase): @override_settings( - PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), + PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls", TEMPLATES=[{ 'BACKEND': 'django.template.backends.django.DjangoTemplates', @@ -4522,7 +4522,7 @@ class ValidXHTMLTests(TestCase): self.assertNotContains(response, ' xml:lang=""') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls", USE_THOUSAND_SEPARATOR=True, USE_L10N=True) class DateHierarchyTests(TestCase): @@ -4645,7 +4645,7 @@ class DateHierarchyTests(TestCase): self.assert_non_localized_year(response, 2005) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminCustomSaveRelatedTests(TestCase): """ @@ -4714,7 +4714,7 @@ class AdminCustomSaveRelatedTests(TestCase): self.assertEqual(['Catherine Stone', 'Paul Stone'], children_names) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminViewLogoutTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -4740,7 +4740,7 @@ class AdminViewLogoutTest(TestCase): self.assertContains(response, '<input type="hidden" name="next" value="/test_admin/admin/" />') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminUserMessageTest(TestCase): fixtures = ['admin-views-users.xml'] @@ -4795,7 +4795,7 @@ class AdminUserMessageTest(TestCase): html=True) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminKeepChangeListFiltersTests(TestCase): fixtures = ['admin-views-users.xml'] @@ -5078,7 +5078,7 @@ class NamespacedAdminKeepChangeListFiltersTests(AdminKeepChangeListFiltersTests) admin_site = site2 -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class TestLabelVisibility(TestCase): """ #11277 -Labels of hidden fields in admin were not hidden. """ @@ -5119,7 +5119,7 @@ class TestLabelVisibility(TestCase): self.assertContains(response, '<div class="form-row hidden') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class AdminViewOnSiteTests(TestCase): fixtures = ['admin-views-users.xml', 'admin-views-restaurants.xml'] @@ -5237,7 +5237,7 @@ class AdminViewOnSiteTests(TestCase): self.assertIsNone(model_admin.get_view_on_site_url(Worker())) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls") class InlineAdminViewOnSiteTest(TestCase): fixtures = ['admin-views-users.xml', 'admin-views-restaurants.xml'] @@ -5287,7 +5287,7 @@ class TestEtagWithAdminView(TestCase): @override_settings( - PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), + PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="admin_views.urls", ) class GetFormsetsWithInlinesArgumentTest(TestCase): diff --git a/tests/admin_widgets/tests.py b/tests/admin_widgets/tests.py index c5795c87fb..c2855bb237 100644 --- a/tests/admin_widgets/tests.py +++ b/tests/admin_widgets/tests.py @@ -167,7 +167,7 @@ class AdminFormfieldForDBFieldTests(TestCase): self.assertEqual(six.text_type(f.help_text), 'Hold down "Control", or "Command" on a Mac, to select more than one.') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_widgets.urls') class AdminFormfieldForDBFieldWithRequestTests(DjangoTestCase): fixtures = ["admin-widgets-users.xml"] @@ -182,7 +182,7 @@ class AdminFormfieldForDBFieldWithRequestTests(DjangoTestCase): self.assertContains(response, "Volkswagon Passat") -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_widgets.urls') class AdminForeignKeyWidgetChangeList(DjangoTestCase): fixtures = ["admin-widgets-users.xml"] @@ -195,7 +195,7 @@ class AdminForeignKeyWidgetChangeList(DjangoTestCase): self.assertContains(response, '/auth/user/add/') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_widgets.urls') class AdminForeignKeyRawIdWidget(DjangoTestCase): fixtures = ["admin-widgets-users.xml"] @@ -537,7 +537,7 @@ class RelatedFieldWidgetWrapperTests(DjangoTestCase): self.assertFalse(wrapper.can_delete_related) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_widgets.urls') class DateTimePickerSeleniumFirefoxTests(AdminSeleniumWebDriverTestCase): @@ -715,7 +715,7 @@ class DateTimePickerSeleniumIETests(DateTimePickerSeleniumFirefoxTests): @skipIf(pytz is None, "this test requires pytz") @override_settings(TIME_ZONE='Asia/Singapore') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_widgets.urls') class DateTimePickerShortcutsSeleniumFirefoxTests(AdminSeleniumWebDriverTestCase): available_apps = ['admin_widgets'] + AdminSeleniumWebDriverTestCase.available_apps @@ -783,7 +783,7 @@ class DateTimePickerShortcutsSeleniumIETests(DateTimePickerShortcutsSeleniumFire webdriver_class = 'selenium.webdriver.ie.webdriver.WebDriver' -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_widgets.urls') class HorizontalVerticalFilterSeleniumFirefoxTests(AdminSeleniumWebDriverTestCase): @@ -1038,7 +1038,7 @@ class HorizontalVerticalFilterSeleniumIETests(HorizontalVerticalFilterSeleniumFi webdriver_class = 'selenium.webdriver.ie.webdriver.WebDriver' -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_widgets.urls') class AdminRawIdWidgetSeleniumFirefoxTests(AdminSeleniumWebDriverTestCase): available_apps = ['admin_widgets'] + AdminSeleniumWebDriverTestCase.available_apps @@ -1129,7 +1129,7 @@ class AdminRawIdWidgetSeleniumIETests(AdminRawIdWidgetSeleniumFirefoxTests): webdriver_class = 'selenium.webdriver.ie.webdriver.WebDriver' -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='admin_widgets.urls') class RelatedFieldWidgetSeleniumFirefoxTests(AdminSeleniumWebDriverTestCase): available_apps = ['admin_widgets'] + AdminSeleniumWebDriverTestCase.available_apps diff --git a/tests/cache/tests.py b/tests/cache/tests.py index db2edf5f26..c17ef12ae0 100644 --- a/tests/cache/tests.py +++ b/tests/cache/tests.py @@ -1508,10 +1508,10 @@ class CacheHEADTest(TestCase): 'BACKEND': 'django.core.cache.backends.locmem.LocMemCache', }, }, - LANGUAGES=( + LANGUAGES=[ ('en', 'English'), ('es', 'Spanish'), - ), + ], ) class CacheI18nTest(TestCase): diff --git a/tests/check_framework/tests.py b/tests/check_framework/tests.py index ea4a8766bf..d15988b117 100644 --- a/tests/check_framework/tests.py +++ b/tests/check_framework/tests.py @@ -113,7 +113,7 @@ class MessageTests(TestCase): class Django_1_7_0_CompatibilityChecks(TestCase): - @override_settings(MIDDLEWARE_CLASSES=('django.contrib.sessions.middleware.SessionMiddleware',)) + @override_settings(MIDDLEWARE_CLASSES=['django.contrib.sessions.middleware.SessionMiddleware']) def test_middleware_classes_overridden(self): errors = check_1_7_compatibility() self.assertEqual(errors, []) diff --git a/tests/context_processors/tests.py b/tests/context_processors/tests.py index d7c7390189..f6c6600402 100644 --- a/tests/context_processors/tests.py +++ b/tests/context_processors/tests.py @@ -48,7 +48,7 @@ class RequestContextProcessorTests(TestCase): @override_settings( DEBUG=True, - INTERNAL_IPS=('127.0.0.1',), + INTERNAL_IPS=['127.0.0.1'], ROOT_URLCONF='context_processors.urls', TEMPLATES=[{ 'BACKEND': 'django.template.backends.django.DjangoTemplates', diff --git a/tests/file_uploads/tests.py b/tests/file_uploads/tests.py index 610cf13630..7036c199d0 100644 --- a/tests/file_uploads/tests.py +++ b/tests/file_uploads/tests.py @@ -28,7 +28,7 @@ MEDIA_ROOT = sys_tempfile.mkdtemp(dir=os.environ['DJANGO_TEST_TEMP_DIR']) UPLOAD_TO = os.path.join(MEDIA_ROOT, 'test_upload') -@override_settings(MEDIA_ROOT=MEDIA_ROOT, ROOT_URLCONF='file_uploads.urls', MIDDLEWARE_CLASSES=()) +@override_settings(MEDIA_ROOT=MEDIA_ROOT, ROOT_URLCONF='file_uploads.urls', MIDDLEWARE_CLASSES=[]) class FileUploadTests(TestCase): @classmethod diff --git a/tests/forms_tests/tests/test_input_formats.py b/tests/forms_tests/tests/test_input_formats.py index f939821c75..60e153db4c 100644 --- a/tests/forms_tests/tests/test_input_formats.py +++ b/tests/forms_tests/tests/test_input_formats.py @@ -10,7 +10,7 @@ from django.test import SimpleTestCase class LocalizedTimeTests(SimpleTestCase): def setUp(self): # nl/formats.py has customized TIME_INPUT_FORMATS: - # ('%H:%M:%S', '%H.%M:%S', '%H.%M', '%H:%M') + # ['%H:%M:%S', '%H.%M:%S', '%H.%M', '%H:%M'] activate('nl') def tearDown(self): diff --git a/tests/generic_inline_admin/tests.py b/tests/generic_inline_admin/tests.py index 1458f6f73f..325d94c7a7 100644 --- a/tests/generic_inline_admin/tests.py +++ b/tests/generic_inline_admin/tests.py @@ -17,7 +17,7 @@ from .models import Episode, Media, EpisodePermanent, Category # Set TEMPLATE_DEBUG to True to ensure {% include %} will raise exceptions. # That is how inlines are rendered and #9498 will bubble up if it is an issue. -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], TEMPLATE_DEBUG=True, ROOT_URLCONF="generic_inline_admin.urls") class GenericAdminViewTest(TestCase): @@ -123,7 +123,7 @@ class GenericAdminViewTest(TestCase): self.assertTrue(formset.get_queryset().ordered) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="generic_inline_admin.urls") class GenericInlineAdminParametersTest(TestCase): fixtures = ['users.xml'] @@ -270,7 +270,7 @@ class GenericInlineAdminParametersTest(TestCase): self.assertEqual(formset.max_num, 2) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF="generic_inline_admin.urls") class GenericInlineAdminWithUniqueTogetherTest(TestCase): fixtures = ['users.xml'] diff --git a/tests/i18n/contenttypes/tests.py b/tests/i18n/contenttypes/tests.py index 23b1ac6c73..a93f2030f2 100644 --- a/tests/i18n/contenttypes/tests.py +++ b/tests/i18n/contenttypes/tests.py @@ -12,14 +12,14 @@ from django.utils import translation @override_settings( USE_I18N=True, - LOCALE_PATHS=( + LOCALE_PATHS=[ os.path.join(os.path.dirname(upath(__file__)), 'locale'), - ), + ], LANGUAGE_CODE='en', - LANGUAGES=( + LANGUAGES=[ ('en', 'English'), ('fr', 'French'), - ), + ], ) class ContentTypeTests(TestCase): def test_verbose_name(self): diff --git a/tests/i18n/patterns/tests.py b/tests/i18n/patterns/tests.py index 2bf770434b..f96ac82fc4 100644 --- a/tests/i18n/patterns/tests.py +++ b/tests/i18n/patterns/tests.py @@ -18,19 +18,19 @@ class PermanentRedirectLocaleMiddleWare(LocaleMiddleware): @override_settings( USE_I18N=True, - LOCALE_PATHS=( + LOCALE_PATHS=[ os.path.join(os.path.dirname(upath(__file__)), 'locale'), - ), + ], LANGUAGE_CODE='en-us', - LANGUAGES=( + LANGUAGES=[ ('nl', 'Dutch'), ('en', 'English'), ('pt-br', 'Brazilian Portuguese'), - ), - MIDDLEWARE_CLASSES=( + ], + MIDDLEWARE_CLASSES=[ 'django.middleware.locale.LocaleMiddleware', 'django.middleware.common.CommonMiddleware', - ), + ], ROOT_URLCONF='i18n.patterns.urls.default', TEMPLATES=[{ 'BACKEND': 'django.template.backends.django.DjangoTemplates', @@ -193,10 +193,10 @@ class URLRedirectTests(URLTestCaseBase): self.assertEqual(response.status_code, 200) @override_settings( - MIDDLEWARE_CLASSES=( + MIDDLEWARE_CLASSES=[ 'i18n.patterns.tests.PermanentRedirectLocaleMiddleWare', 'django.middleware.common.CommonMiddleware', - ), + ], ) def test_custom_redirect_class(self): response = self.client.get('/account/register/', HTTP_ACCEPT_LANGUAGE='en') diff --git a/tests/i18n/test_compilation.py b/tests/i18n/test_compilation.py index bc76a5337c..c17db0a98a 100644 --- a/tests/i18n/test_compilation.py +++ b/tests/i18n/test_compilation.py @@ -92,7 +92,7 @@ class PercentRenderingTests(MessageCompilationTests): self.addCleanup(os.unlink, os.path.join(self.test_dir, self.MO_FILE)) def test_percent_symbol_escaping(self): - with override_settings(LOCALE_PATHS=(os.path.join(self.test_dir, 'locale'),)): + with override_settings(LOCALE_PATHS=[os.path.join(self.test_dir, 'locale')]): from django.template import Template, Context call_command('compilemessages', locale=[self.LOCALE], stdout=StringIO()) with translation.override(self.LOCALE): @@ -119,13 +119,13 @@ class MultipleLocaleCompilationTests(MessageCompilationTests): self.addCleanup(self.rmfile, os.path.join(localedir, self.MO_FILE_FR)) def test_one_locale(self): - with override_settings(LOCALE_PATHS=(os.path.join(self.test_dir, 'locale'),)): + with override_settings(LOCALE_PATHS=[os.path.join(self.test_dir, 'locale')]): call_command('compilemessages', locale=['hr'], stdout=StringIO()) self.assertTrue(os.path.exists(self.MO_FILE_HR)) def test_multiple_locales(self): - with override_settings(LOCALE_PATHS=(os.path.join(self.test_dir, 'locale'),)): + with override_settings(LOCALE_PATHS=[os.path.join(self.test_dir, 'locale')]): call_command('compilemessages', locale=['hr', 'fr'], stdout=StringIO()) self.assertTrue(os.path.exists(self.MO_FILE_HR)) @@ -202,14 +202,14 @@ class FuzzyTranslationTest(MessageCompilationTests): gettext_module._translations = {} # flush cache or test will be useless def test_nofuzzy_compiling(self): - with override_settings(LOCALE_PATHS=(os.path.join(self.test_dir, 'locale'),)): + with override_settings(LOCALE_PATHS=[os.path.join(self.test_dir, 'locale')]): call_command('compilemessages', locale=[self.LOCALE], stdout=StringIO()) with translation.override(self.LOCALE): self.assertEqual(ugettext('Lenin'), force_text('Ленин')) self.assertEqual(ugettext('Vodka'), force_text('Vodka')) def test_fuzzy_compiling(self): - with override_settings(LOCALE_PATHS=(os.path.join(self.test_dir, 'locale'),)): + with override_settings(LOCALE_PATHS=[os.path.join(self.test_dir, 'locale')]): call_command('compilemessages', locale=[self.LOCALE], fuzzy=True, stdout=StringIO()) with translation.override(self.LOCALE): self.assertEqual(ugettext('Lenin'), force_text('Ленин')) diff --git a/tests/i18n/test_extraction.py b/tests/i18n/test_extraction.py index 94948b203e..99d4983b43 100644 --- a/tests/i18n/test_extraction.py +++ b/tests/i18n/test_extraction.py @@ -721,8 +721,7 @@ class CustomLayoutExtractionTests(ExtractorTests): management.call_command('makemessages', locale=LOCALE, verbosity=0) @override_settings( - LOCALE_PATHS=(os.path.join( - this_directory, 'project_dir', 'project_locale'),) + LOCALE_PATHS=[os.path.join(this_directory, 'project_dir', 'project_locale')], ) def test_project_locale_paths(self): """ diff --git a/tests/i18n/tests.py b/tests/i18n/tests.py index 0b5714d6bf..cbc31828b4 100644 --- a/tests/i18n/tests.py +++ b/tests/i18n/tests.py @@ -42,9 +42,9 @@ from .models import Company, TestModel here = os.path.dirname(os.path.abspath(upath(__file__))) -extended_locale_paths = settings.LOCALE_PATHS + ( +extended_locale_paths = settings.LOCALE_PATHS + [ os.path.join(here, 'other', 'locale'), -) +] @contextmanager @@ -397,7 +397,7 @@ class TranslationTests(TestCase): self.assertEqual(trans_real.to_language('en_US'), 'en-us') self.assertEqual(trans_real.to_language('sr_Lat'), 'sr-lat') - @override_settings(LOCALE_PATHS=(os.path.join(here, 'other', 'locale'),)) + @override_settings(LOCALE_PATHS=[os.path.join(here, 'other', 'locale')]) def test_bad_placeholder_1(self): """ Error in translation file should not crash template rendering @@ -409,7 +409,7 @@ class TranslationTests(TestCase): rendered = t.render(Context({'person': 'James'})) self.assertEqual(rendered, 'My name is James.') - @override_settings(LOCALE_PATHS=(os.path.join(here, 'other', 'locale'),)) + @override_settings(LOCALE_PATHS=[os.path.join(here, 'other', 'locale')]) def test_bad_placeholder_2(self): """ Error in translation file should not crash template rendering @@ -998,11 +998,11 @@ class MiscTests(TestCase): self.assertEqual('zh-hant', g(r)) @override_settings( - LANGUAGES=( + LANGUAGES=[ ('en', 'English'), ('zh-hans', 'Simplified Chinese'), ('zh-hant', 'Traditional Chinese'), - ) + ] ) def test_support_for_deprecated_chinese_language_codes(self): """ @@ -1112,7 +1112,7 @@ class MiscTests(TestCase): r.COOKIES = {} r.META = {'HTTP_ACCEPT_LANGUAGE': 'pt-br'} self.assertEqual('pt-br', g(r)) - with self.settings(LANGUAGES=(('en', 'English'),)): + with self.settings(LANGUAGES=[('en', 'English')]): self.assertNotEqual('pt-br', g(r)) @@ -1342,14 +1342,14 @@ class MultipleLocaleActivationTests(TestCase): @override_settings( USE_I18N=True, - LANGUAGES=( + LANGUAGES=[ ('en', 'English'), ('fr', 'French'), - ), - MIDDLEWARE_CLASSES=( + ], + MIDDLEWARE_CLASSES=[ 'django.middleware.locale.LocaleMiddleware', 'django.middleware.common.CommonMiddleware', - ), + ], ROOT_URLCONF='i18n.urls', ) class LocaleMiddlewareTests(TestCase): @@ -1362,11 +1362,11 @@ class LocaleMiddlewareTests(TestCase): self.assertContains(response, "Yes/No") @override_settings( - MIDDLEWARE_CLASSES=( + MIDDLEWARE_CLASSES=[ 'django.contrib.sessions.middleware.SessionMiddleware', 'django.middleware.locale.LocaleMiddleware', 'django.middleware.common.CommonMiddleware', - ), + ], ) def test_language_not_saved_to_session(self): """Checks that current language is not automatically saved to @@ -1378,15 +1378,15 @@ class LocaleMiddlewareTests(TestCase): @override_settings( USE_I18N=True, - LANGUAGES=( + LANGUAGES=[ ('bg', 'Bulgarian'), ('en-us', 'English'), ('pt-br', 'Portugese (Brazil)'), - ), - MIDDLEWARE_CLASSES=( + ], + MIDDLEWARE_CLASSES=[ 'django.middleware.locale.LocaleMiddleware', 'django.middleware.common.CommonMiddleware', - ), + ], ROOT_URLCONF='i18n.urls' ) class CountrySpecificLanguageTests(TestCase): diff --git a/tests/logging_tests/tests.py b/tests/logging_tests/tests.py index 65b2be4135..3e4c19ece5 100644 --- a/tests/logging_tests/tests.py +++ b/tests/logging_tests/tests.py @@ -185,7 +185,7 @@ class AdminEmailHandlerTest(TestCase): self.assertTrue(admin_email_handler.connection().fail_silently) @override_settings( - ADMINS=(('whatever admin', 'admin@example.com'),), + ADMINS=[('whatever admin', 'admin@example.com')], EMAIL_SUBJECT_PREFIX='-SuperAwesomeSubject-' ) def test_accepts_args(self): @@ -215,9 +215,9 @@ class AdminEmailHandlerTest(TestCase): admin_email_handler.filters = orig_filters @override_settings( - ADMINS=(('whatever admin', 'admin@example.com'),), + ADMINS=[('whatever admin', 'admin@example.com')], EMAIL_SUBJECT_PREFIX='-SuperAwesomeSubject-', - INTERNAL_IPS=('127.0.0.1',), + INTERNAL_IPS=['127.0.0.1'], ) def test_accepts_args_and_request(self): """ @@ -250,7 +250,7 @@ class AdminEmailHandlerTest(TestCase): admin_email_handler.filters = orig_filters @override_settings( - ADMINS=(('admin', 'admin@example.com'),), + ADMINS=[('admin', 'admin@example.com')], EMAIL_SUBJECT_PREFIX='', DEBUG=False, ) @@ -295,7 +295,7 @@ class AdminEmailHandlerTest(TestCase): self.assertEqual(mail.outbox[0].subject, expected_subject) @override_settings( - ADMINS=(('admin', 'admin@example.com'),), + ADMINS=[('admin', 'admin@example.com')], DEBUG=False, ) def test_uses_custom_email_backend(self): @@ -327,7 +327,7 @@ class AdminEmailHandlerTest(TestCase): admin_email_handler.email_backend = orig_email_backend @override_settings( - ADMINS=(('whatever admin', 'admin@example.com'),), + ADMINS=[('whatever admin', 'admin@example.com')], ) def test_emit_non_ascii(self): """ @@ -347,7 +347,7 @@ class AdminEmailHandlerTest(TestCase): self.assertIn("path:%s" % url_path, msg.body) @override_settings( - MANAGERS=(('manager', 'manager@example.com'),), + MANAGERS=[('manager', 'manager@example.com')], DEBUG=False, ) def test_customize_send_mail_method(self): @@ -423,7 +423,7 @@ class SecurityLoggerTest(TestCase): self.assertEqual(calls[0], 'dubious') @override_settings( - ADMINS=(('admin', 'admin@example.com'),), + ADMINS=[('admin', 'admin@example.com')], DEBUG=False, ) def test_suspicious_email_admins(self): diff --git a/tests/mail/tests.py b/tests/mail/tests.py index 5b5c9e1c70..683f47fe31 100644 --- a/tests/mail/tests.py +++ b/tests/mail/tests.py @@ -606,7 +606,7 @@ class BaseEmailBackendTests(HeadersCheckMixin, object): message = self.get_the_message() self.assertEqual(message.get('subject'), '[Django] Subject') - @override_settings(ADMINS=(), MANAGERS=()) + @override_settings(ADMINS=[], MANAGERS=[]) def test_empty_admins(self): """ Test that mail_admins/mail_managers doesn't connect to the mail server diff --git a/tests/middleware/tests.py b/tests/middleware/tests.py index 770d500444..c7620732b5 100644 --- a/tests/middleware/tests.py +++ b/tests/middleware/tests.py @@ -277,8 +277,8 @@ class CommonMiddlewareTest(TestCase): @override_settings( - IGNORABLE_404_URLS=(re.compile(r'foo'),), - MANAGERS=('PHB@dilbert.com',), + IGNORABLE_404_URLS=[re.compile(r'foo')], + MANAGERS=['PHB@dilbert.com'], ) class BrokenLinkEmailsMiddlewareTest(TestCase): diff --git a/tests/middleware_exceptions/tests.py b/tests/middleware_exceptions/tests.py index 8c191e4ea5..9c7a24ec22 100644 --- a/tests/middleware_exceptions/tests.py +++ b/tests/middleware_exceptions/tests.py @@ -868,9 +868,9 @@ class MiddlewareNotUsedTests(TestCase): with self.assertRaises(MiddlewareNotUsed): MyMiddleware().process_request(request) - @override_settings(MIDDLEWARE_CLASSES=( + @override_settings(MIDDLEWARE_CLASSES=[ 'middleware_exceptions.tests.MyMiddleware', - )) + ]) def test_log(self): with patch_logger('django.request', 'debug') as calls: self.client.get('/middleware_exceptions/view/') @@ -880,9 +880,9 @@ class MiddlewareNotUsedTests(TestCase): "MiddlewareNotUsed: 'middleware_exceptions.tests.MyMiddleware'" ) - @override_settings(MIDDLEWARE_CLASSES=( + @override_settings(MIDDLEWARE_CLASSES=[ 'middleware_exceptions.tests.MyMiddlewareWithExceptionMessage', - )) + ]) def test_log_custom_message(self): with patch_logger('django.request', 'debug') as calls: self.client.get('/middleware_exceptions/view/') diff --git a/tests/model_regress/test_pickle.py b/tests/model_regress/test_pickle.py index 5348b4a495..64d2f6df5f 100644 --- a/tests/model_regress/test_pickle.py +++ b/tests/model_regress/test_pickle.py @@ -71,7 +71,7 @@ from django.conf import settings data = %r -settings.configure(DEBUG=False, INSTALLED_APPS=('model_regress',), SECRET_KEY = "blah") +settings.configure(DEBUG=False, INSTALLED_APPS=['model_regress'], SECRET_KEY = "blah") article = pickle.loads(data) print(article.headline)""" a = Article.objects.create( diff --git a/tests/proxy_models/tests.py b/tests/proxy_models/tests.py index cb4ea3c9eb..131bd1524f 100644 --- a/tests/proxy_models/tests.py +++ b/tests/proxy_models/tests.py @@ -380,7 +380,7 @@ class ProxyModelTests(TestCase): self.assertEqual(MyPerson(id=100), Person(id=100)) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='proxy_models.urls',) class ProxyModelAdminTests(TestCase): fixtures = ['myhorses'] diff --git a/tests/runtests.py b/tests/runtests.py index 6cb589b935..e232da9c63 100755 --- a/tests/runtests.py +++ b/tests/runtests.py @@ -50,13 +50,13 @@ ALWAYS_INSTALLED_APPS = [ 'django.contrib.staticfiles', ] -ALWAYS_MIDDLEWARE_CLASSES = ( +ALWAYS_MIDDLEWARE_CLASSES = [ 'django.contrib.sessions.middleware.SessionMiddleware', 'django.middleware.common.CommonMiddleware', 'django.middleware.csrf.CsrfViewMiddleware', 'django.contrib.auth.middleware.AuthenticationMiddleware', 'django.contrib.messages.middleware.MessageMiddleware', -) +] def get_test_modules(): @@ -116,7 +116,7 @@ def setup(verbosity, test_labels): settings.STATIC_URL = '/static/' settings.STATIC_ROOT = os.path.join(TEMP_DIR, 'static') # Remove the following line in Django 2.0. - settings.TEMPLATE_DIRS = (TEMPLATE_DIR,) + settings.TEMPLATE_DIRS = [TEMPLATE_DIR] settings.TEMPLATES = [{ 'BACKEND': 'django.template.backends.django.DjangoTemplates', 'DIRS': [TEMPLATE_DIR], diff --git a/tests/settings_tests/tests.py b/tests/settings_tests/tests.py index 0befd18e29..8d39d6c1b1 100644 --- a/tests/settings_tests/tests.py +++ b/tests/settings_tests/tests.py @@ -441,12 +441,12 @@ class IsOverriddenTest(TestCase): self.assertTrue(settings.is_overridden('ALLOWED_HOSTS')) -class TestTupleSettings(unittest.TestCase): +class TestListSettings(unittest.TestCase): """ - Make sure settings that should be tuples throw ImproperlyConfigured if they - are set to a string instead of a tuple. + Make sure settings that should be lists or tuples throw + ImproperlyConfigured if they are set to a string instead of a list or tuple. """ - tuple_settings = ( + list_or_tuple_settings = ( "ALLOWED_INCLUDE_ROOTS", "INSTALLED_APPS", "TEMPLATE_DIRS", @@ -456,8 +456,8 @@ class TestTupleSettings(unittest.TestCase): def test_tuple_settings(self): settings_module = ModuleType('fake_settings_module') settings_module.SECRET_KEY = 'foo' - for setting in self.tuple_settings: - setattr(settings_module, setting, ('non_tuple_value')) + for setting in self.list_or_tuple_settings: + setattr(settings_module, setting, ('non_list_or_tuple_value')) sys.modules['fake_settings_module'] = settings_module try: with self.assertRaises(ImproperlyConfigured): diff --git a/tests/staticfiles_tests/tests.py b/tests/staticfiles_tests/tests.py index 1d5ccfc075..43cee9e636 100644 --- a/tests/staticfiles_tests/tests.py +++ b/tests/staticfiles_tests/tests.py @@ -33,16 +33,16 @@ TEST_SETTINGS = { 'STATIC_URL': '/static/', 'MEDIA_ROOT': os.path.join(TEST_ROOT, 'project', 'site_media', 'media'), 'STATIC_ROOT': os.path.join(TEST_ROOT, 'project', 'site_media', 'static'), - 'STATICFILES_DIRS': ( + 'STATICFILES_DIRS': [ os.path.join(TEST_ROOT, 'project', 'documents'), ('prefix', os.path.join(TEST_ROOT, 'project', 'prefixed')), - ), - 'STATICFILES_FINDERS': ( + ], + 'STATICFILES_FINDERS': [ 'django.contrib.staticfiles.finders.FileSystemFinder', 'django.contrib.staticfiles.finders.AppDirectoriesFinder', 'django.contrib.staticfiles.finders.DefaultStorageFinder', - ), - 'INSTALLED_APPS': ( + ], + 'INSTALLED_APPS': [ 'django.contrib.contenttypes', 'django.contrib.auth', 'django.contrib.admin.apps.SimpleAdminConfig', @@ -50,7 +50,7 @@ TEST_SETTINGS = { 'staticfiles_tests', 'staticfiles_tests.apps.test', 'staticfiles_tests.apps.no_label', - ), + ], } from django.contrib.staticfiles.management.commands.collectstatic import Command as CollectstaticCommand @@ -600,8 +600,8 @@ class TestHashedFiles(object): self.assertIn(b"other.d41d8cd98f00.css", content) @override_settings( - STATICFILES_DIRS=(os.path.join(TEST_ROOT, 'project', 'faulty'),), - STATICFILES_FINDERS=('django.contrib.staticfiles.finders.FileSystemFinder',), + STATICFILES_DIRS=[os.path.join(TEST_ROOT, 'project', 'faulty')], + STATICFILES_FINDERS=['django.contrib.staticfiles.finders.FileSystemFinder'], ) def test_post_processing_failure(self): """ @@ -898,7 +898,7 @@ class TestDefaultStorageFinder(StaticFilesTestCase, FinderTestCase): @override_settings( - STATICFILES_FINDERS=('django.contrib.staticfiles.finders.FileSystemFinder',), + STATICFILES_FINDERS=['django.contrib.staticfiles.finders.FileSystemFinder'], STATICFILES_DIRS=[os.path.join(TEST_ROOT, 'project', 'documents')], ) class TestMiscFinder(TestCase): diff --git a/tests/template_tests/test_response.py b/tests/template_tests/test_response.py index 3807789e63..5c73265ded 100644 --- a/tests/template_tests/test_response.py +++ b/tests/template_tests/test_response.py @@ -333,7 +333,7 @@ class TemplateResponseTest(SimpleTestCase): @override_settings( - MIDDLEWARE_CLASSES=list(settings.MIDDLEWARE_CLASSES) + [ + MIDDLEWARE_CLASSES=settings.MIDDLEWARE_CLASSES + [ 'template_tests.test_response.CustomURLConfMiddleware' ], ROOT_URLCONF='template_tests.urls', @@ -348,7 +348,7 @@ class CustomURLConfTest(SimpleTestCase): @override_settings( CACHE_MIDDLEWARE_SECONDS=2.0, - MIDDLEWARE_CLASSES=list(settings.MIDDLEWARE_CLASSES) + [ + MIDDLEWARE_CLASSES=settings.MIDDLEWARE_CLASSES + [ 'django.middleware.cache.FetchFromCacheMiddleware', 'django.middleware.cache.UpdateCacheMiddleware', ], diff --git a/tests/test_client/tests.py b/tests/test_client/tests.py index cf96b89a62..7059c23a81 100644 --- a/tests/test_client/tests.py +++ b/tests/test_client/tests.py @@ -30,7 +30,7 @@ from django.test import override_settings from .views import get_view, post_view, trace_view -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='test_client.urls',) class ClientTest(TestCase): fixtures = ['testdata.json'] @@ -530,7 +530,7 @@ class ClientTest(TestCase): @override_settings( - MIDDLEWARE_CLASSES=('django.middleware.csrf.CsrfViewMiddleware',), + MIDDLEWARE_CLASSES=['django.middleware.csrf.CsrfViewMiddleware'], ROOT_URLCONF='test_client.urls', ) class CSRFEnabledClientTests(TestCase): diff --git a/tests/test_client_regress/tests.py b/tests/test_client_regress/tests.py index 2d97823854..c97ad550d1 100644 --- a/tests/test_client_regress/tests.py +++ b/tests/test_client_regress/tests.py @@ -188,7 +188,7 @@ class AssertContainsTests(TestCase): self.assertNotContains(response, 'Bye') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='test_client_regress.urls',) class AssertTemplateUsedTests(TestCase): fixtures = ['testdata.json'] @@ -810,7 +810,7 @@ class AssertFormsetErrorTests(TestCase): **kwargs) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='test_client_regress.urls',) class LoginTests(TestCase): fixtures = ['testdata'] @@ -833,7 +833,7 @@ class LoginTests(TestCase): @override_settings( - PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), + PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], SESSION_ENGINE='test_client_regress.session', ROOT_URLCONF='test_client_regress.urls', ) @@ -879,7 +879,7 @@ class URLEscapingTests(TestCase): self.assertEqual(response.content, b'Hi, Arthur') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='test_client_regress.urls',) class ExceptionTests(TestCase): fixtures = ['testdata.json'] @@ -948,7 +948,7 @@ class zzUrlconfSubstitutionTests(TestCase): reverse('arg_view', args=['somename']) -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='test_client_regress.urls',) class ContextTests(TestCase): fixtures = ['testdata'] @@ -1023,7 +1023,7 @@ class ContextTests(TestCase): self.assertEqual(response.context['nested'], 'yes') -@override_settings(PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), +@override_settings(PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='test_client_regress.urls',) class SessionTests(TestCase): fixtures = ['testdata.json'] diff --git a/tests/test_sqlite.py b/tests/test_sqlite.py index 6bce452c79..18d413a682 100644 --- a/tests/test_sqlite.py +++ b/tests/test_sqlite.py @@ -24,6 +24,6 @@ DATABASES = { SECRET_KEY = "django_tests_secret_key" # Use a fast hasher to speed up tests. -PASSWORD_HASHERS = ( +PASSWORD_HASHERS = [ 'django.contrib.auth.hashers.MD5PasswordHasher', -) +] diff --git a/tests/timezones/tests.py b/tests/timezones/tests.py index 677d51ac2e..a8ee433464 100644 --- a/tests/timezones/tests.py +++ b/tests/timezones/tests.py @@ -1074,7 +1074,7 @@ class NewFormsTests(TestCase): @override_settings(DATETIME_FORMAT='c', TIME_ZONE='Africa/Nairobi', USE_L10N=False, USE_TZ=True, - PASSWORD_HASHERS=('django.contrib.auth.hashers.SHA1PasswordHasher',), + PASSWORD_HASHERS=['django.contrib.auth.hashers.SHA1PasswordHasher'], ROOT_URLCONF='timezones.urls') class AdminTests(TestCase): diff --git a/tests/urlpatterns_reverse/tests.py b/tests/urlpatterns_reverse/tests.py index 50a0881a41..7b46d0a0a3 100644 --- a/tests/urlpatterns_reverse/tests.py +++ b/tests/urlpatterns_reverse/tests.py @@ -538,9 +538,9 @@ class RequestURLconfTests(TestCase): self.assertEqual(response.status_code, 404) @override_settings( - MIDDLEWARE_CLASSES=( + MIDDLEWARE_CLASSES=[ '%s.ChangeURLconfMiddleware' % middleware.__name__, - ) + ] ) def test_urlconf_overridden(self): response = self.client.get('/test/me/') @@ -552,18 +552,18 @@ class RequestURLconfTests(TestCase): self.assertEqual(response.content, b'outer:,inner:/second_test/') @override_settings( - MIDDLEWARE_CLASSES=( + MIDDLEWARE_CLASSES=[ '%s.NullChangeURLconfMiddleware' % middleware.__name__, - ) + ] ) def test_urlconf_overridden_with_null(self): self.assertRaises(ImproperlyConfigured, self.client.get, '/test/me/') @override_settings( - MIDDLEWARE_CLASSES=( + MIDDLEWARE_CLASSES=[ '%s.ChangeURLconfMiddleware' % middleware.__name__, '%s.ReverseInnerInResponseMiddleware' % middleware.__name__, - ) + ] ) def test_reverse_inner_in_response_middleware(self): """ @@ -575,10 +575,10 @@ class RequestURLconfTests(TestCase): self.assertEqual(response.content, b'/second_test/') @override_settings( - MIDDLEWARE_CLASSES=( + MIDDLEWARE_CLASSES=[ '%s.ChangeURLconfMiddleware' % middleware.__name__, '%s.ReverseOuterInResponseMiddleware' % middleware.__name__, - ) + ] ) def test_reverse_outer_in_response_middleware(self): """ @@ -590,10 +590,10 @@ class RequestURLconfTests(TestCase): self.client.get('/second_test/') @override_settings( - MIDDLEWARE_CLASSES=( + MIDDLEWARE_CLASSES=[ '%s.ChangeURLconfMiddleware' % middleware.__name__, '%s.ReverseInnerInStreaming' % middleware.__name__, - ) + ] ) def test_reverse_inner_in_streaming(self): """ @@ -605,10 +605,10 @@ class RequestURLconfTests(TestCase): self.assertEqual(b''.join(response), b'/second_test/') @override_settings( - MIDDLEWARE_CLASSES=( + MIDDLEWARE_CLASSES=[ '%s.ChangeURLconfMiddleware' % middleware.__name__, '%s.ReverseOuterInStreaming' % middleware.__name__, - ) + ] ) def test_reverse_outer_in_streaming(self): """ diff --git a/tests/utils_tests/test_autoreload.py b/tests/utils_tests/test_autoreload.py index bcb7d1a448..c0865cba57 100644 --- a/tests/utils_tests/test_autoreload.py +++ b/tests/utils_tests/test_autoreload.py @@ -27,7 +27,7 @@ class TestFilenameGenerator(TestCase): 'nl', 'LC_MESSAGES', 'django.mo'), filenames) - @override_settings(LOCALE_PATHS=(LOCALE_PATH,)) + @override_settings(LOCALE_PATHS=[LOCALE_PATH]) def test_locale_paths_setting(self): """ Test that gen_filenames also yields from LOCALE_PATHS locales. diff --git a/tests/view_tests/tests/test_csrf.py b/tests/view_tests/tests/test_csrf.py index 893a7e200b..26ec221e01 100644 --- a/tests/view_tests/tests/test_csrf.py +++ b/tests/view_tests/tests/test_csrf.py @@ -11,11 +11,11 @@ class CsrfViewTests(TestCase): @override_settings( USE_I18N=True, - MIDDLEWARE_CLASSES=( + MIDDLEWARE_CLASSES=[ 'django.middleware.locale.LocaleMiddleware', 'django.middleware.common.CommonMiddleware', 'django.middleware.csrf.CsrfViewMiddleware', - ), + ], ) def test_translation(self): """ diff --git a/tests/view_tests/tests/test_debug.py b/tests/view_tests/tests/test_debug.py index be6ceff1b5..8645bd3e8e 100644 --- a/tests/view_tests/tests/test_debug.py +++ b/tests/view_tests/tests/test_debug.py @@ -546,7 +546,7 @@ class ExceptionReportTestMixin(object): """ Asserts that potentially sensitive info are displayed in the email report. """ - with self.settings(ADMINS=(('Admin', 'admin@fattie-breakie.com'),)): + with self.settings(ADMINS=[('Admin', 'admin@fattie-breakie.com')]): mail.outbox = [] # Empty outbox request = self.rf.post('/some_url/', self.breakfast_data) view(request) @@ -579,7 +579,7 @@ class ExceptionReportTestMixin(object): """ Asserts that certain sensitive info are not displayed in the email report. """ - with self.settings(ADMINS=(('Admin', 'admin@fattie-breakie.com'),)): + with self.settings(ADMINS=[('Admin', 'admin@fattie-breakie.com')]): mail.outbox = [] # Empty outbox request = self.rf.post('/some_url/', self.breakfast_data) view(request) @@ -619,7 +619,7 @@ class ExceptionReportTestMixin(object): """ Asserts that no variables or POST parameters are displayed in the email report. """ - with self.settings(ADMINS=(('Admin', 'admin@fattie-breakie.com'),)): + with self.settings(ADMINS=[('Admin', 'admin@fattie-breakie.com')]): mail.outbox = [] # Empty outbox request = self.rf.post('/some_url/', self.breakfast_data) view(request) diff --git a/tests/view_tests/tests/test_i18n.py b/tests/view_tests/tests/test_i18n.py index 5185a5c458..ba51d3289b 100644 --- a/tests/view_tests/tests/test_i18n.py +++ b/tests/view_tests/tests/test_i18n.py @@ -51,7 +51,7 @@ class I18NTests(TestCase): # we force saving language to a cookie rather than a session # by excluding session middleware and those which do require it test_settings = dict( - MIDDLEWARE_CLASSES=('django.middleware.common.CommonMiddleware',), + MIDDLEWARE_CLASSES=['django.middleware.common.CommonMiddleware'], LANGUAGE_COOKIE_NAME='mylanguage', LANGUAGE_COOKIE_AGE=3600 * 7 * 2, LANGUAGE_COOKIE_DOMAIN='.example.com', @@ -193,9 +193,13 @@ class JsI18NTestsMultiPackage(TestCase): self.assertContains(response, 'este texto de app3 debe ser traducido') def test_i18n_with_locale_paths(self): - extended_locale_paths = settings.LOCALE_PATHS + ( - path.join(path.dirname( - path.dirname(path.abspath(upath(__file__)))), 'app3', 'locale'),) + extended_locale_paths = settings.LOCALE_PATHS + [ + path.join( + path.dirname(path.dirname(path.abspath(upath(__file__)))), + 'app3', + 'locale', + ), + ] with self.settings(LANGUAGE_CODE='es-ar', LOCALE_PATHS=extended_locale_paths): with override('es-ar'): response = self.client.get('/jsi18n/') |
