summaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorIuri de Silvio <iurisilvio@gmail.com>2021-04-08 16:31:45 -0300
committerMariusz Felisiak <felisiak.mariusz@gmail.com>2021-04-13 06:16:19 +0200
commitb245845575154905701a71d34a4d0c4d21f2f6b3 (patch)
tree1e3eeea399a3fce4ed4247008b95dbc341932e52 /tests
parent98db3c76fcdac76e2c6d770aaac5c711a91209f4 (diff)
[3.2.x] Fixed #32627 -- Fixed QuerySet.values()/values_list() crash on combined querysets ordered by unannotated columns.
Backport of 9760e262f85ae57df39abe2799eff48a82b14474 from main
Diffstat (limited to 'tests')
-rw-r--r--tests/queries/test_qs_combinators.py20
1 files changed, 19 insertions, 1 deletions
diff --git a/tests/queries/test_qs_combinators.py b/tests/queries/test_qs_combinators.py
index 81c7b2e3a3..07712d73f6 100644
--- a/tests/queries/test_qs_combinators.py
+++ b/tests/queries/test_qs_combinators.py
@@ -5,7 +5,7 @@ from django.db.models import Exists, F, IntegerField, OuterRef, Value
from django.test import TestCase, skipIfDBFeature, skipUnlessDBFeature
from django.test.utils import CaptureQueriesContext
-from .models import Number, ReservedName
+from .models import Celebrity, Number, ReservedName
@skipUnlessDBFeature('supports_select_union')
@@ -234,6 +234,24 @@ class QuerySetSetOperationTests(TestCase):
operator.itemgetter('num'),
)
+ def test_union_multiple_models_with_values_list_and_order(self):
+ reserved_name = ReservedName.objects.create(name='rn1', order=0)
+ qs1 = Celebrity.objects.all()
+ qs2 = ReservedName.objects.all()
+ self.assertSequenceEqual(
+ qs1.union(qs2).order_by('name').values_list('pk', flat=True),
+ [reserved_name.pk],
+ )
+
+ def test_union_multiple_models_with_values_list_and_order_by_extra_select(self):
+ reserved_name = ReservedName.objects.create(name='rn1', order=0)
+ qs1 = Celebrity.objects.extra(select={'extra_name': 'name'})
+ qs2 = ReservedName.objects.extra(select={'extra_name': 'name'})
+ self.assertSequenceEqual(
+ qs1.union(qs2).order_by('extra_name').values_list('pk', flat=True),
+ [reserved_name.pk],
+ )
+
def test_count_union(self):
qs1 = Number.objects.filter(num__lte=1).values('num')
qs2 = Number.objects.filter(num__gte=2, num__lte=3).values('num')