diff options
| author | nessita <124304+nessita@users.noreply.github.com> | 2025-04-01 13:52:22 -0300 |
|---|---|---|
| committer | Natalia <124304+nessita@users.noreply.github.com> | 2025-04-01 13:55:05 -0300 |
| commit | 614be94957d6b17a8b3d051204e62559e1f089e6 (patch) | |
| tree | bc708598cd635cb99ae0d3dd878935299a34b9c7 /js_tests/admin | |
| parent | 88ca180bfe9940e338b5d4eca5079fd2280c752c (diff) | |
[5.2.x] Fixed #36284, Refs #31170 -- Ensured related lookup popups are closed properly.
In the admin, when selecting related objects via the helpers defined in
`RelatedObjectLookups.js`, the `dismissRelatedLookupPopup` function was
attempting to access `window.relatedWindows`, which does not exist in
real execution, causing related lookup popups to remain open.
This change ensures that this code correctly accesses the module-local
`relatedWindows` by explicitly assigning it to `window.relatedWindows`.
Regression in 91bebf1adb43561b54bac18e76224759dc70acb3.
Thanks Matthias Kestenholz for the report, the fix ideas, and testing.
Co-authored-by: Matthias Kestenholz <mk@feinheit.ch>
Backport of a245604277eb9edeba234dacf199890766462709 from main.
Diffstat (limited to 'js_tests/admin')
| -rw-r--r-- | js_tests/admin/RelatedObjectLookups.test.js | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/js_tests/admin/RelatedObjectLookups.test.js b/js_tests/admin/RelatedObjectLookups.test.js index 722aa7ae7b..0d71d88f2a 100644 --- a/js_tests/admin/RelatedObjectLookups.test.js +++ b/js_tests/admin/RelatedObjectLookups.test.js @@ -8,7 +8,6 @@ QUnit.module('admin.RelatedObjectLookups', { <input type="text" id="test_id" name="test" /> <input type="text" id="many_test_id" name="many_test" class="vManyToManyRawIdAdminField" /> `); - window.relatedWindows = window.relatedWindows || []; } }); |