diff options
| author | Nick Pope <nick.pope@flightdataservices.com> | 2019-02-05 11:22:08 +0000 |
|---|---|---|
| committer | Tim Graham <timograham@gmail.com> | 2019-02-06 13:48:39 -0500 |
| commit | 24b82cd201e21060fbc02117dc16d1702877a1f3 (patch) | |
| tree | 7d36db9251700d0abf8fbf69399c8abc7fd9026a /django/forms/forms.py | |
| parent | 21bb71ef0dcb86798edb0d8b21138bcc4b947590 (diff) | |
Fixed #30159 -- Removed unneeded use of OrderedDict.
Dicts preserve order since Python 3.6.
Diffstat (limited to 'django/forms/forms.py')
| -rw-r--r-- | django/forms/forms.py | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/django/forms/forms.py b/django/forms/forms.py index 51e6465539..0c49a94432 100644 --- a/django/forms/forms.py +++ b/django/forms/forms.py @@ -3,7 +3,6 @@ Form classes """ import copy -from collections import OrderedDict from django.core.exceptions import NON_FIELD_ERRORS, ValidationError # BoundField is imported for backwards compatibility in Django 1.9 @@ -31,12 +30,12 @@ class DeclarativeFieldsMetaclass(MediaDefiningClass): if isinstance(value, Field): current_fields.append((key, value)) attrs.pop(key) - attrs['declared_fields'] = OrderedDict(current_fields) + attrs['declared_fields'] = dict(current_fields) new_class = super(DeclarativeFieldsMetaclass, mcs).__new__(mcs, name, bases, attrs) # Walk through the MRO. - declared_fields = OrderedDict() + declared_fields = {} for base in reversed(new_class.__mro__): # Collect fields from base class. if hasattr(base, 'declared_fields'): @@ -52,11 +51,6 @@ class DeclarativeFieldsMetaclass(MediaDefiningClass): return new_class - @classmethod - def __prepare__(metacls, name, bases, **kwds): - # Remember the order in which form fields are defined. - return OrderedDict() - @html_safe class BaseForm: @@ -129,7 +123,7 @@ class BaseForm: """ if field_order is None: return - fields = OrderedDict() + fields = {} for key in field_order: try: fields[key] = self.fields.pop(key) |
