summaryrefslogtreecommitdiff
path: root/django/forms/fields.py
diff options
context:
space:
mode:
authorNatalia <124304+nessita@users.noreply.github.com>2025-01-06 15:51:45 -0300
committerNatalia <124304+nessita@users.noreply.github.com>2025-01-14 09:00:34 -0300
commite8d4a2005955dcf962193600b53bf461b190b455 (patch)
treee0dd2bbb171e8b223f00783932b7edcd08cc6eaf /django/forms/fields.py
parent5e63880cb854844a811b4ee062ee9ac695f6809e (diff)
[5.0.x] Fixed CVE-2024-56374 -- Mitigated potential DoS in IPv6 validation.
Thanks Saravana Kumar for the report, and Sarah Boyce and Mariusz Felisiak for the reviews. Co-authored-by: Natalia <124304+nessita@users.noreply.github.com>
Diffstat (limited to 'django/forms/fields.py')
-rw-r--r--django/forms/fields.py7
1 files changed, 5 insertions, 2 deletions
diff --git a/django/forms/fields.py b/django/forms/fields.py
index f00d567a3a..fe6cacc6da 100644
--- a/django/forms/fields.py
+++ b/django/forms/fields.py
@@ -46,7 +46,7 @@ from django.utils.choices import normalize_choices
from django.utils.dateparse import parse_datetime, parse_duration
from django.utils.deprecation import RemovedInDjango60Warning
from django.utils.duration import duration_string
-from django.utils.ipv6 import clean_ipv6_address
+from django.utils.ipv6 import MAX_IPV6_ADDRESS_LENGTH, clean_ipv6_address
from django.utils.regex_helper import _lazy_re_compile
from django.utils.translation import gettext_lazy as _
from django.utils.translation import ngettext_lazy
@@ -1295,6 +1295,7 @@ class GenericIPAddressField(CharField):
self.default_validators = validators.ip_address_validators(
protocol, unpack_ipv4
)[0]
+ kwargs.setdefault("max_length", MAX_IPV6_ADDRESS_LENGTH)
super().__init__(**kwargs)
def to_python(self, value):
@@ -1302,7 +1303,9 @@ class GenericIPAddressField(CharField):
return ""
value = value.strip()
if value and ":" in value:
- return clean_ipv6_address(value, self.unpack_ipv4)
+ return clean_ipv6_address(
+ value, self.unpack_ipv4, max_length=self.max_length
+ )
return value