From 315fe20086ae1cd784e097c0b93e7fa5aca7a6c5 Mon Sep 17 00:00:00 2001
From: Eli Zaretskii <eliz@gnu.org>
Date: Sat, 9 Oct 2021 11:23:44 +0300
Subject: ; * src/Makefile.in (../native-lisp): Add comment.

---
 src/Makefile.in | 9 +++++++++
 1 file changed, 9 insertions(+)

(limited to 'src')

diff --git a/src/Makefile.in b/src/Makefile.in
index 0326b4a8f22..6d75e3537a6 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -803,6 +803,15 @@ elnlisp := $(addprefix ${lispsource}/,${elnlisp}) $(lisp:.elc=.eln)
 	@$(MAKE) $(AM_V_NO_PD) -C ../lisp EMACS="../src/emacs$(EXEEXT)"\
 		THEFILE=$< $<n
 
+## FIXME: this is fragile!  We lie to Make about the files produced by
+## this rule, and we rely on the absence of the native-lisp directory
+## to trigger it.  This means that if anything goes wrong during
+## native compilation, the only way to trigger it again is to remove
+## the directory and re-native-compile everything.  The main
+## underlying problem is that the name of the subdirectory of
+## native-lisp where the *.eln files will be produced, and the exact
+## names of those *.eln files, cannot be known in advance; we must ask
+## Emacs to produce them.
 ../native-lisp: | $(pdmp)
 	@if test ! -d $@; then \
 	  mkdir $@ && $(MAKE) $(AM_V_NO_PD) $(elnlisp); \
-- 
cgit v1.3


From 00eb21c8979f4e53345fdc021d32307d102afda9 Mon Sep 17 00:00:00 2001
From: Eli Zaretskii <eliz@gnu.org>
Date: Sat, 9 Oct 2021 14:38:06 +0300
Subject: ; * src/dispextern.h (struct glyph_string): Comment on NCHARS. 
 (Bug#51105)

---
 src/dispextern.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/dispextern.h b/src/dispextern.h
index 6aefe43e195..08dac5d4557 100644
--- a/src/dispextern.h
+++ b/src/dispextern.h
@@ -1326,7 +1326,9 @@ struct glyph_string
   /* The area within row.  */
   enum glyph_row_area area;
 
-  /* Characters to be drawn, and number of characters.  */
+  /* Characters to be drawn, and number of characters.  Note that
+     NCHARS can be zero if this is a composition glyph string, as
+     evidenced by FIRST_GLYPH->type.  */
   unsigned *char2b;
   int nchars;
 
-- 
cgit v1.3