diff options
| author | Eli Zaretskii <eliz@gnu.org> | 2011-08-05 13:32:06 +0300 |
|---|---|---|
| committer | Eli Zaretskii <eliz@gnu.org> | 2011-08-05 13:32:06 +0300 |
| commit | e2e2423bf2fe3cda60737f20aeafaff64d38b35e (patch) | |
| tree | 6748333a8b45cee55b4b4c9ef5085c7285c5e5ad /src | |
| parent | 1abfdc54d7ce46cf2e799c79b7f655360040fb61 (diff) | |
Fix bug #9229 with cursor positioning on display strings.
src/xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
came from a string character with a `cursor' property.
Diffstat (limited to 'src')
| -rw-r--r-- | src/ChangeLog | 5 | ||||
| -rw-r--r-- | src/xdisp.c | 21 |
2 files changed, 17 insertions, 9 deletions
diff --git a/src/ChangeLog b/src/ChangeLog index 8ed6761e1dd..5861ee6c48b 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,8 @@ +2011-08-05 Eli Zaretskii <eliz@gnu.org> + + * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that + came from a string character with a `cursor' property. (Bug#9229) + 2011-08-04 Jan Djärv <jan.h.d@swipnet.se> * Makefile.in (LIB_PTHREAD): New variable. diff --git a/src/xdisp.c b/src/xdisp.c index d1598e5ed40..59a6bc3f906 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -13706,14 +13706,12 @@ set_cursor_from_row (struct window *w, struct glyph_row *row, w->cursor.vpos >= 0 /* that candidate is not the row we are processing */ && MATRIX_ROW (matrix, w->cursor.vpos) != row - /* the row we are processing is part of a continued line */ - && (row->continued_p || MATRIX_ROW_CONTINUATION_LINE_P (row)) /* Make sure cursor.vpos specifies a row whose start and end charpos occlude point. This is because some callers of this function leave cursor.vpos at the row where the cursor was displayed during the last redisplay cycle. */ && MATRIX_ROW_START_CHARPOS (MATRIX_ROW (matrix, w->cursor.vpos)) <= pt_old - && pt_old < MATRIX_ROW_END_CHARPOS (MATRIX_ROW (matrix, w->cursor.vpos))) + && pt_old <= MATRIX_ROW_END_CHARPOS (MATRIX_ROW (matrix, w->cursor.vpos))) { struct glyph *g1 = MATRIX_ROW_GLYPH_START (matrix, w->cursor.vpos) + w->cursor.hpos; @@ -13722,15 +13720,20 @@ set_cursor_from_row (struct window *w, struct glyph_row *row, if (!(row->reversed_p ? glyph > glyphs_end : glyph < glyphs_end)) return 0; /* Keep the candidate whose buffer position is the closest to - point. */ + point or has the `cursor' property. */ if (/* previous candidate is a glyph in TEXT_AREA of that row */ w->cursor.hpos >= 0 && w->cursor.hpos < MATRIX_ROW_USED (matrix, w->cursor.vpos) - && BUFFERP (g1->object) - && (g1->charpos == pt_old /* an exact match always wins */ - || (BUFFERP (glyph->object) - && eabs (g1->charpos - pt_old) - < eabs (glyph->charpos - pt_old)))) + && ((BUFFERP (g1->object) + && (g1->charpos == pt_old /* an exact match always wins */ + || (BUFFERP (glyph->object) + && eabs (g1->charpos - pt_old) + < eabs (glyph->charpos - pt_old)))) + /* previous candidate is a glyph from a string that has + a non-nil `cursor' property */ + || (STRINGP (g1->object) + && !NILP (Fget_char_property (make_number (g1->charpos), + Qcursor, g1->object))))) return 0; /* If this candidate gives an exact match, use that. */ if (!(BUFFERP (glyph->object) && glyph->charpos == pt_old) |