summaryrefslogtreecommitdiff
path: root/java/org/gnu/emacs/EmacsInputConnection.java
diff options
context:
space:
mode:
authorPo Lu <luangruo@yahoo.com>2023-06-15 12:36:50 +0800
committerPo Lu <luangruo@yahoo.com>2023-06-15 12:36:50 +0800
commit363e293cc919ab02c40bd9a8fa4875c2e5644b2d (patch)
tree5fa537364e29fbcdb13cd195ac6da253a6d95771 /java/org/gnu/emacs/EmacsInputConnection.java
parentca120044ac11d38ca1e8cac7903be38d5ca15d2b (diff)
Update Android port
* java/org/gnu/emacs/EmacsInputConnection.java (EmacsInputConnection, beginBatchEdit, reset, endBatchEdit): Keep track of the number of batch edits and return an appropriate value. (takeSnapshot): Implement function. * java/org/gnu/emacs/EmacsNative.java (takeSnapshot): New function. * java/org/gnu/emacs/EmacsService.java (resetIC): Improve debugging output. * java/org/gnu/emacs/EmacsView.java (onCreateInputConnection): Call `reset' to clear the UI side batch edit count. * src/androidterm.c (struct android_get_surrounding_text_context): New fields `conversion_start' and `conversion_end'. (android_get_surrounding_text): Return the conversion region. (android_get_surrounding_text_internal, NATIVE_NAME): Factor out `getSurroundingText'. (takeSnapshot): New function.
Diffstat (limited to 'java/org/gnu/emacs/EmacsInputConnection.java')
-rw-r--r--java/org/gnu/emacs/EmacsInputConnection.java66
1 files changed, 52 insertions, 14 deletions
diff --git a/java/org/gnu/emacs/EmacsInputConnection.java b/java/org/gnu/emacs/EmacsInputConnection.java
index 1bcc9a62a81..f8dce5dfa79 100644
--- a/java/org/gnu/emacs/EmacsInputConnection.java
+++ b/java/org/gnu/emacs/EmacsInputConnection.java
@@ -50,6 +50,11 @@ public final class EmacsInputConnection implements InputConnection
/* The handle ID associated with that view's window. */
private short windowHandle;
+ /* Number of batch edits currently underway. Used to avoid
+ synchronizing with the Emacs thread after each
+ `endBatchEdit'. */
+ private int batchEditCount;
+
/* Whether or not to synchronize and call `updateIC' with the
selection position after committing text.
@@ -110,6 +115,10 @@ public final class EmacsInputConnection implements InputConnection
Log.d (TAG, "beginBatchEdit");
EmacsNative.beginBatchEdit (windowHandle);
+
+ /* Keep a record of the number of outstanding batch edits here as
+ well. */
+ batchEditCount++;
return true;
}
@@ -125,7 +134,14 @@ public final class EmacsInputConnection implements InputConnection
Log.d (TAG, "endBatchEdit");
EmacsNative.endBatchEdit (windowHandle);
- return true;
+
+ /* Subtract one from the UI thread record of the number of batch
+ edits currently under way. */
+
+ if (batchEditCount > 0)
+ batchEditCount -= 1;
+
+ return batchEditCount > 0;
}
public boolean
@@ -584,21 +600,50 @@ public final class EmacsInputConnection implements InputConnection
return text;
}
-
- /* Override functions which are not implemented. */
-
@Override
- public Handler
- getHandler ()
+ public TextSnapshot
+ takeSnapshot ()
{
- return null;
+ TextSnapshot snapshot;
+
+ /* Return if the input connection is out of date. */
+ if (view.icSerial < view.icGeneration)
+ return null;
+
+ snapshot = EmacsNative.takeSnapshot (windowHandle);
+
+ if (EmacsService.DEBUG_IC)
+ Log.d (TAG, ("takeSnapshot: "
+ + snapshot.getSurroundingText ().getText ()
+ + " @ " + snapshot.getCompositionEnd ()
+ + ", " + snapshot.getCompositionStart ()));
+
+ return snapshot;
}
@Override
public void
closeConnection ()
{
+ batchEditCount = 0;
+ }
+
+
+ public void
+ reset ()
+ {
+ batchEditCount = 0;
+ }
+
+
+ /* Override functions which are not implemented. */
+
+ @Override
+ public Handler
+ getHandler ()
+ {
+ return null;
}
@Override
@@ -617,13 +662,6 @@ public final class EmacsInputConnection implements InputConnection
}
@Override
- public TextSnapshot
- takeSnapshot ()
- {
- return null;
- }
-
- @Override
public boolean
clearMetaKeyStates (int states)
{