From fcc4e251dbc917118f73d7187ee2f4cbf3883f36 Mon Sep 17 00:00:00 2001 From: Jeff Date: Wed, 23 May 2018 15:55:27 -0400 Subject: Fixed #29000 -- Fixed RenameModel's renaming of a M2M column when run after RenameField. Regression in 45ded053b1f4320284aa5dac63052f6d1baefea9. --- tests/migrations/test_operations.py | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) (limited to 'tests') diff --git a/tests/migrations/test_operations.py b/tests/migrations/test_operations.py index b5c9fb1b3d..d70feaacdb 100644 --- a/tests/migrations/test_operations.py +++ b/tests/migrations/test_operations.py @@ -802,6 +802,34 @@ class OperationTests(OperationTestBase): self.assertEqual(PonyRider.objects.count(), 2) self.assertEqual(pony.riders.count(), 2) + def test_rename_m2m_model_after_rename_field(self): + """RenameModel renames a many-to-many column after a RenameField.""" + app_label = 'test_rename_multiple' + project_state = self.apply_operations(app_label, ProjectState(), operations=[ + migrations.CreateModel('Pony', fields=[ + ('id', models.AutoField(primary_key=True)), + ('name', models.CharField(max_length=20)), + ]), + migrations.CreateModel('Rider', fields=[ + ('id', models.AutoField(primary_key=True)), + ('pony', models.ForeignKey('test_rename_multiple.Pony', models.CASCADE)), + ]), + migrations.CreateModel('PonyRider', fields=[ + ('id', models.AutoField(primary_key=True)), + ('riders', models.ManyToManyField('Rider')), + ]), + migrations.RenameField(model_name='pony', old_name='name', new_name='fancy_name'), + migrations.RenameModel(old_name='Rider', new_name='Jockey'), + ], atomic=connection.features.supports_atomic_references_rename) + Pony = project_state.apps.get_model(app_label, 'Pony') + Jockey = project_state.apps.get_model(app_label, 'Jockey') + PonyRider = project_state.apps.get_model(app_label, 'PonyRider') + # No "no such column" error means the column was renamed correctly. + pony = Pony.objects.create(fancy_name='a good name') + jockey = Jockey.objects.create(pony=pony) + ponyrider = PonyRider.objects.create() + ponyrider.riders.add(jockey) + def test_add_field(self): """ Tests the AddField operation. -- cgit v1.3