From d9ba8fa3972dd78c38cc94c08ad6514e8a2e237d Mon Sep 17 00:00:00 2001 From: Nathaniel Conroy Date: Sun, 26 Nov 2023 18:36:56 -0500 Subject: [5.0.x] Fixed #34992 -- Fixed DatabaseFeatures.allows_group_by_selected_pks on MariaDB with ONLY_FULL_GROUP_BY sql mode. Regression in 041551d716b69ee7c81199eee86a2d10a72e15ab. Backport of 0257426fe1fe9d146fd5813f09d909917ff59360 from main --- tests/backends/mysql/test_features.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'tests') diff --git a/tests/backends/mysql/test_features.py b/tests/backends/mysql/test_features.py index 96e1ed3b49..4e5c7c294f 100644 --- a/tests/backends/mysql/test_features.py +++ b/tests/backends/mysql/test_features.py @@ -28,3 +28,21 @@ class TestFeatures(TestCase): _connection.sql_mode = {"NO_AUTO_VALUE_ON_ZERO"} database_features = DatabaseFeatures(_connection) self.assertIs(database_features.allows_auto_pk_0, True) + + def test_allows_group_by_selected_pks(self): + with mock.MagicMock() as _connection: + _connection.mysql_is_mariadb = False + database_features = DatabaseFeatures(_connection) + self.assertIs(database_features.allows_group_by_selected_pks, True) + + with mock.MagicMock() as _connection: + _connection.mysql_is_mariadb = False + _connection.sql_mode = {} + database_features = DatabaseFeatures(_connection) + self.assertIs(database_features.allows_group_by_selected_pks, True) + + with mock.MagicMock() as _connection: + _connection.mysql_is_mariadb = True + _connection.sql_mode = {"ONLY_FULL_GROUP_BY"} + database_features = DatabaseFeatures(_connection) + self.assertIs(database_features.allows_group_by_selected_pks, False) -- cgit v1.3