From d03b130cbcc629daa5ae767588b2fff41ea1e48a Mon Sep 17 00:00:00 2001 From: oliver Date: Sun, 17 Jun 2018 04:18:57 +0900 Subject: [2.1.x] Fixed #29469 -- Added a helpful makemigrations error if app_label contains dots. Backport of 78972af367a1da54aa7e539e4b1ffa2b56571e77 from master --- tests/migrations/test_commands.py | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'tests') diff --git a/tests/migrations/test_commands.py b/tests/migrations/test_commands.py index 933c00eada..76b8e39b17 100644 --- a/tests/migrations/test_commands.py +++ b/tests/migrations/test_commands.py @@ -786,6 +786,12 @@ class MakeMigrationsTests(MigrationTestBase): call_command("makemigrations", "this_app_does_not_exist", stderr=err) self.assertIn("'this_app_does_not_exist' could not be found.", err.getvalue()) + def test_makemigrations_app_name_with_dots(self): + err = io.StringIO() + with self.assertRaises(SystemExit): + call_command('makemigrations', 'invalid.app.label', stderr=err) + self.assertIn("'invalid.app.label' is not a valid app label. Did you mean 'label'?", err.getvalue()) + def test_makemigrations_empty_no_app_specified(self): """ makemigrations exits if no app is specified with 'empty' mode. -- cgit v1.3