From b50815ee418b38e719476c2d5f6e2bc69f686927 Mon Sep 17 00:00:00 2001 From: Simon Charette Date: Tue, 24 May 2016 15:29:11 -0400 Subject: Refs #25530 -- Renamed deferred SQL references on rename operation. --- tests/backends/test_ddl_references.py | 58 +++++++++++++++++++++++++++++++++++ tests/schema/tests.py | 29 ++++++++++++++++++ 2 files changed, 87 insertions(+) (limited to 'tests') diff --git a/tests/backends/test_ddl_references.py b/tests/backends/test_ddl_references.py index 268eed988b..dc5b8750a0 100644 --- a/tests/backends/test_ddl_references.py +++ b/tests/backends/test_ddl_references.py @@ -12,6 +12,14 @@ class TableTests(SimpleTestCase): self.assertIs(self.reference.references_table('table'), True) self.assertIs(self.reference.references_table('other'), False) + def test_rename_table_references(self): + self.reference.rename_table_references('other', 'table') + self.assertIs(self.reference.references_table('table'), True) + self.assertIs(self.reference.references_table('other'), False) + self.reference.rename_table_references('table', 'other') + self.assertIs(self.reference.references_table('table'), False) + self.assertIs(self.reference.references_table('other'), True) + def test_repr(self): self.assertEqual(repr(self.reference), "") @@ -30,6 +38,18 @@ class ColumnsTests(TableTests): self.assertIs(self.reference.references_column('table', 'third_column'), False) self.assertIs(self.reference.references_column('table', 'first_column'), True) + def test_rename_column_references(self): + self.reference.rename_column_references('other', 'first_column', 'third_column') + self.assertIs(self.reference.references_column('table', 'first_column'), True) + self.assertIs(self.reference.references_column('table', 'third_column'), False) + self.assertIs(self.reference.references_column('other', 'third_column'), False) + self.reference.rename_column_references('table', 'third_column', 'first_column') + self.assertIs(self.reference.references_column('table', 'first_column'), True) + self.assertIs(self.reference.references_column('table', 'third_column'), False) + self.reference.rename_column_references('table', 'first_column', 'third_column') + self.assertIs(self.reference.references_column('table', 'first_column'), False) + self.assertIs(self.reference.references_column('table', 'third_column'), True) + def test_repr(self): self.assertEqual(repr(self.reference), "") @@ -72,6 +92,21 @@ class ForeignKeyNameTests(IndexNameTests): self.assertIs(self.reference.references_column('to_table', 'second_column'), False) self.assertIs(self.reference.references_column('to_table', 'to_second_column'), True) + def test_rename_table_references(self): + super().test_rename_table_references() + self.reference.rename_table_references('to_table', 'other_to_table') + self.assertIs(self.reference.references_table('other_to_table'), True) + self.assertIs(self.reference.references_table('to_table'), False) + + def test_rename_column_references(self): + super().test_rename_column_references() + self.reference.rename_column_references('to_table', 'second_column', 'third_column') + self.assertIs(self.reference.references_column('table', 'second_column'), True) + self.assertIs(self.reference.references_column('to_table', 'to_second_column'), True) + self.reference.rename_column_references('to_table', 'to_first_column', 'to_third_column') + self.assertIs(self.reference.references_column('to_table', 'to_first_column'), False) + self.assertIs(self.reference.references_column('to_table', 'to_third_column'), True) + def test_repr(self): self.assertEqual( repr(self.reference), @@ -99,6 +134,17 @@ class MockReference(object): def references_column(self, table, column): return (table, column) in self.referenced_columns + def rename_table_references(self, old_table, new_table): + if old_table in self.referenced_tables: + self.referenced_tables.remove(old_table) + self.referenced_tables.add(new_table) + + def rename_column_references(self, table, old_column, new_column): + column = (table, old_column) + if column in self.referenced_columns: + self.referenced_columns.remove(column) + self.referenced_columns.add((table, new_column)) + def __str__(self): return self.representation @@ -114,6 +160,18 @@ class StatementTests(SimpleTestCase): self.assertIs(statement.references_column('table', 'column'), True) self.assertIs(statement.references_column('other', 'column'), False) + def test_rename_table_references(self): + reference = MockReference('', {'table'}, {}) + statement = Statement('', reference=reference, non_reference='') + statement.rename_table_references('table', 'other') + self.assertEqual(reference.referenced_tables, {'other'}) + + def test_rename_column_references(self): + reference = MockReference('', {}, {('table', 'column')}) + statement = Statement('', reference=reference, non_reference='') + statement.rename_column_references('table', 'column', 'other') + self.assertEqual(reference.referenced_columns, {('table', 'other')}) + def test_repr(self): reference = MockReference('reference', {}, {}) statement = Statement("%(reference)s - %(non_reference)s", reference=reference, non_reference='non_reference') diff --git a/tests/schema/tests.py b/tests/schema/tests.py index d2707ecea7..f4612a5dee 100644 --- a/tests/schema/tests.py +++ b/tests/schema/tests.py @@ -2359,3 +2359,32 @@ class SchemaTests(TransactionTestCase): doc = Document.objects.create(name='Test Name') student = Student.objects.create(name='Some man') doc.students.add(student) + + def test_rename_table_renames_deferred_sql_references(self): + with connection.schema_editor() as editor: + editor.create_model(Author) + editor.create_model(Book) + editor.alter_db_table(Author, 'schema_author', 'schema_renamed_author') + editor.alter_db_table(Author, 'schema_book', 'schema_renamed_book') + self.assertGreater(len(editor.deferred_sql), 0) + for statement in editor.deferred_sql: + self.assertIs(statement.references_table('schema_author'), False) + self.assertIs(statement.references_table('schema_book'), False) + + @unittest.skipIf(connection.vendor == 'sqlite', 'SQLite naively remakes the table on field alteration.') + def test_rename_column_renames_deferred_sql_references(self): + with connection.schema_editor() as editor: + editor.create_model(Author) + editor.create_model(Book) + old_title = Book._meta.get_field('title') + new_title = CharField(max_length=100, db_index=True) + new_title.set_attributes_from_name('renamed_title') + editor.alter_field(Book, old_title, new_title) + old_author = Book._meta.get_field('author') + new_author = ForeignKey(Author, CASCADE) + new_author.set_attributes_from_name('renamed_author') + editor.alter_field(Book, old_author, new_author) + self.assertGreater(len(editor.deferred_sql), 0) + for statement in editor.deferred_sql: + self.assertIs(statement.references_column('book', 'title'), False) + self.assertIs(statement.references_column('book', 'author_id'), False) -- cgit v1.3