From 9f2e8b5bb79722ccafa3c4d6816bc847be1f59f9 Mon Sep 17 00:00:00 2001 From: Carles Pina Estany Date: Tue, 25 Apr 2017 00:49:31 +0200 Subject: Fixed #28120 -- Checked that CharField.max_length is not a boolean. --- tests/invalid_models_tests/test_ordinary_fields.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'tests') diff --git a/tests/invalid_models_tests/test_ordinary_fields.py b/tests/invalid_models_tests/test_ordinary_fields.py index 9b5b57834d..90f4b31902 100644 --- a/tests/invalid_models_tests/test_ordinary_fields.py +++ b/tests/invalid_models_tests/test_ordinary_fields.py @@ -139,6 +139,21 @@ class CharFieldTests(TestCase): ] self.assertEqual(errors, expected) + def test_str_max_length_type(self): + class Model(models.Model): + field = models.CharField(max_length=True) + + field = Model._meta.get_field('field') + errors = field.check() + expected = [ + Error( + "'max_length' must be a positive integer.", + obj=field, + id='fields.E121' + ), + ] + self.assertEqual(errors, expected) + def test_non_iterable_choices(self): class Model(models.Model): field = models.CharField(max_length=10, choices='bad') -- cgit v1.3