From 84a2b2e7a7d8ac0dd210bcfa299fab8c4f240aae Mon Sep 17 00:00:00 2001 From: Mariusz Felisiak Date: Fri, 4 Nov 2022 09:30:23 +0100 Subject: [4.1.x] Fixed #34138 -- Avoided table rebuild when adding inline m2m fields on SQLite. Regression in 2f73e5406d54cb8945e187eff302a3a3373350be. Thanks David Wobrock for the report. Backport of 7b0e9ea53ca99de2f485ec582f3a79be34b531d4 from main --- tests/schema/tests.py | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/schema/tests.py b/tests/schema/tests.py index 126c03c63c..9c891c015e 100644 --- a/tests/schema/tests.py +++ b/tests/schema/tests.py @@ -2112,8 +2112,25 @@ class SchemaTests(TransactionTestCase): with self.assertRaises(DatabaseError): self.column_classes(new_field.remote_field.through) # Add the field - with connection.schema_editor() as editor: + with CaptureQueriesContext( + connection + ) as ctx, connection.schema_editor() as editor: editor.add_field(LocalAuthorWithM2M, new_field) + # Table is not rebuilt. + self.assertEqual( + len( + [ + query["sql"] + for query in ctx.captured_queries + if "CREATE TABLE" in query["sql"] + ] + ), + 1, + ) + self.assertIs( + any("DROP TABLE" in query["sql"] for query in ctx.captured_queries), + False, + ) # Ensure there is now an m2m table there columns = self.column_classes(new_field.remote_field.through) self.assertEqual( -- cgit v1.3