From 7cddd8a02e60332c0d02f565c450b0eea0d88438 Mon Sep 17 00:00:00 2001 From: Henry Dang Date: Sat, 26 Nov 2016 13:23:03 -0500 Subject: Fixed #27358 -- Added a system check to prevent FileField's upload_to from starting with a slash. Thanks Frank Bijlsma for the initial patch. --- tests/invalid_models_tests/test_ordinary_fields.py | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) (limited to 'tests') diff --git a/tests/invalid_models_tests/test_ordinary_fields.py b/tests/invalid_models_tests/test_ordinary_fields.py index aff6a74659..c005fe9331 100644 --- a/tests/invalid_models_tests/test_ordinary_fields.py +++ b/tests/invalid_models_tests/test_ordinary_fields.py @@ -455,6 +455,31 @@ class FileFieldTests(SimpleTestCase): ] self.assertEqual(errors, expected) + def test_upload_to_starts_with_slash(self): + class Model(models.Model): + field = models.FileField(upload_to='/somewhere') + + field = Model._meta.get_field('field') + self.assertEqual(field.check(), [ + Error( + "FileField's 'upload_to' argument must be a relative path, not " + "an absolute path.", + obj=field, + id='fields.E202', + hint='Remove the leading slash.', + ) + ]) + + def test_upload_to_callable_not_checked(self): + def callable(instance, filename): + return '/' + filename + + class Model(models.Model): + field = models.FileField(upload_to=callable) + + field = Model._meta.get_field('field') + self.assertEqual(field.check(), []) + @isolate_apps('invalid_models_tests') class FilePathFieldTests(SimpleTestCase): -- cgit v1.3