From 7c18b22e2fa70aa8dcfadb33beb17933abdf7ee4 Mon Sep 17 00:00:00 2001 From: Hasan Ramezani Date: Sun, 13 Dec 2020 22:41:20 +0100 Subject: Fixed #32256 -- Fixed migration optimization crash when swapping field names. This disables optimization of RenameField operation when an old field name is referenced in subsequent operations. Co-authored-by: InvalidInterrupt --- tests/migrations/test_optimizer.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'tests') diff --git a/tests/migrations/test_optimizer.py b/tests/migrations/test_optimizer.py index 9bb1aafebd..0caaf66f9e 100644 --- a/tests/migrations/test_optimizer.py +++ b/tests/migrations/test_optimizer.py @@ -572,6 +572,23 @@ class OptimizerTests(SimpleTestCase): ], ) + def test_swapping_fields_names(self): + self.assertDoesNotOptimize( + [ + migrations.CreateModel( + 'MyModel', + [ + ('field_a', models.IntegerField()), + ('field_b', models.IntegerField()), + ], + ), + migrations.RunPython(migrations.RunPython.noop), + migrations.RenameField('MyModel', 'field_a', 'field_c'), + migrations.RenameField('MyModel', 'field_b', 'field_a'), + migrations.RenameField('MyModel', 'field_c', 'field_b'), + ], + ) + def test_create_model_remove_field(self): """ RemoveField should optimize into CreateModel. -- cgit v1.3