From 6e2d9f0aa895b34d5d9c06dddc33d06326e52012 Mon Sep 17 00:00:00 2001 From: Mariusz Felisiak Date: Thu, 30 Nov 2023 10:10:27 +0100 Subject: [4.2.x] Fixed #35006 -- Fixed migrations crash when altering Meta.db_table_comment on SQLite. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks Юрий for the report. Regression in 78f163a4fb3937aca2e71786fbdd51a0ef39629e. Backport of 37fc832a54ad37e75a898a2c8f9ab0820617c4af from main --- tests/schema/tests.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'tests') diff --git a/tests/schema/tests.py b/tests/schema/tests.py index 9bb71de0be..ff8c284812 100644 --- a/tests/schema/tests.py +++ b/tests/schema/tests.py @@ -4727,6 +4727,23 @@ class SchemaTests(TransactionTestCase): [None, ""], ) + @isolate_apps("schema") + @skipIfDBFeature("supports_comments") + def test_db_comment_table_unsupported(self): + class ModelWithDbTableComment(Model): + class Meta: + app_label = "schema" + db_table_comment = "Custom table comment" + + # Table comments are ignored on databases that don't support them. + with connection.schema_editor() as editor, self.assertNumQueries(1): + editor.create_model(ModelWithDbTableComment) + self.isolated_local_models = [ModelWithDbTableComment] + with connection.schema_editor() as editor, self.assertNumQueries(0): + editor.alter_db_table_comment( + ModelWithDbTableComment, "Custom table comment", "New table comment" + ) + @isolate_apps("schema") @skipUnlessDBFeature("supports_comments", "supports_foreign_keys") def test_db_comments_from_abstract_model(self): -- cgit v1.3