From 6dca603abb0eb164ba87657caf5cc65bca449719 Mon Sep 17 00:00:00 2001 From: Daniel Boeve Date: Fri, 6 Sep 2013 18:47:08 +0000 Subject: Fixed #20889 -- Prevented email.Header from inserting newlines Passed large maxlinelen to email.Header to prevent newlines from being inserted into value returned by _convert_to_charset Thanks mjl at laubach.at for the report. --- tests/httpwrappers/tests.py | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'tests') diff --git a/tests/httpwrappers/tests.py b/tests/httpwrappers/tests.py index 356818d2ef..0d9611ef0e 100644 --- a/tests/httpwrappers/tests.py +++ b/tests/httpwrappers/tests.py @@ -290,6 +290,13 @@ class HttpResponseTests(unittest.TestCase): self.assertRaises(UnicodeError, r.__setitem__, 'føø', 'bar') self.assertRaises(UnicodeError, r.__setitem__, 'føø'.encode('utf-8'), 'bar') + def test_long_line(self): + # Bug #20889: long lines trigger newlines to be added to headers + # (which is not allowed due to bug #10188) + h = HttpResponse() + f = 'zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz a\xcc\x88'.encode('latin-1') + f = f.decode('utf-8') + h['Content-Disposition'] = u'attachment; filename="%s"' % f def test_newlines_in_headers(self): # Bug #10188: Do not allow newlines in headers (CR or LF) -- cgit v1.3