From 517d3bb4dd17e9c51690c98d747b86a0ed8b2fbf Mon Sep 17 00:00:00 2001 From: Juan Alvarez Date: Tue, 15 Aug 2023 16:53:30 -0300 Subject: Fixed #34779 -- Avoided unnecessary selection of non-nullable m2m fields without natural keys during serialization. By using `select_related(None)` instead of `select_related()`, the unnecessary joins are completely avoided. Note that the current tests already covers the change, when the field is not `null=True`. Regression in f9936deed1ff13b20e18bd9ca2b0750b52706b6c. --- tests/serializers/models/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/serializers/models/base.py b/tests/serializers/models/base.py index e9f548ad3c..c5a4a0f580 100644 --- a/tests/serializers/models/base.py +++ b/tests/serializers/models/base.py @@ -60,7 +60,7 @@ class TopicManager(models.Manager): class Topic(models.Model): name = models.CharField(max_length=255) - category = models.ForeignKey(Category, models.CASCADE, null=True) + category = models.ForeignKey(Category, models.CASCADE) objects = TopicManager() -- cgit v1.3