From 42e8cf47c7ee2db238bf91197ea398126c546741 Mon Sep 17 00:00:00 2001 From: Simon Charette Date: Mon, 25 Jan 2021 23:32:55 -0500 Subject: Fixed #32369 -- Fixed adding check constraints with pattern lookups and expressions as rhs. This disables interpolation of constraint creation statements. Since Constraint.create_sql interpolates its parameters instead of deferring this responsibility to the backend connection it must disable connection level parameters interpolation. --- tests/migrations/test_operations.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'tests') diff --git a/tests/migrations/test_operations.py b/tests/migrations/test_operations.py index 897808f75b..984aefa23d 100644 --- a/tests/migrations/test_operations.py +++ b/tests/migrations/test_operations.py @@ -2145,6 +2145,7 @@ class OperationTests(OperationTestBase): fields=[ ('id', models.AutoField(primary_key=True)), ('name', models.CharField(max_length=100)), + ('surname', models.CharField(max_length=100, default='')), ('rebate', models.CharField(max_length=100)), ], ), @@ -2178,6 +2179,19 @@ class OperationTests(OperationTestBase): Author.objects.create(name='Albert', rebate='10$') author = Author.objects.create(name='Albert', rebate='10%') self.assertEqual(Author.objects.get(), author) + # Right-hand-side baked "%" literals should not be used for parameters + # interpolation. + check = ~models.Q(surname__startswith=models.F('name')) + constraint = models.CheckConstraint(check=check, name='name_constraint_rhs') + operation = migrations.AddConstraint('Author', constraint) + from_state = to_state + to_state = from_state.clone() + operation.state_forwards(app_label, to_state) + with connection.schema_editor() as editor: + operation.database_forwards(app_label, editor, from_state, to_state) + Author = to_state.apps.get_model(app_label, 'Author') + with self.assertRaises(IntegrityError), transaction.atomic(): + Author.objects.create(name='Albert', surname='Alberto') @skipUnlessDBFeature('supports_table_check_constraints') def test_add_or_constraint(self): -- cgit v1.3