From 41be85862d9067a809ccf3707d2a22dfef23d99a Mon Sep 17 00:00:00 2001 From: François Freitag Date: Mon, 9 Oct 2017 13:20:01 -0700 Subject: Fixed #28679 -- Fixed urlencode()'s handling of bytes. Regression in fee42fd99ee470528858c2ccb3621135c30ec262. Thanks Claude Paroz, Jon Dufresne, and Tim Graham for the guidance. --- tests/utils_tests/test_http.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'tests') diff --git a/tests/utils_tests/test_http.py b/tests/utils_tests/test_http.py index a7a670c85b..41bda81967 100644 --- a/tests/utils_tests/test_http.py +++ b/tests/utils_tests/test_http.py @@ -47,6 +47,23 @@ class URLEncodeTests(unittest.TestCase): 'position=Developer&name=Adrian&name=Simon', ]) + def test_dict_with_bytes_values(self): + self.assertEqual(urlencode({'a': b'abc'}, doseq=True), 'a=abc') + + def test_dict_with_sequence_of_bytes(self): + self.assertEqual(urlencode({'a': [b'spam', b'eggs', b'bacon']}, doseq=True), 'a=spam&a=eggs&a=bacon') + + def test_dict_with_bytearray(self): + self.assertEqual(urlencode({'a': bytearray(range(2))}, doseq=True), 'a=0&a=1') + self.assertEqual(urlencode({'a': bytearray(range(2))}, doseq=False), 'a=%5B%270%27%2C+%271%27%5D') + + def test_generator(self): + def gen(): + yield from range(2) + + self.assertEqual(urlencode({'a': gen()}, doseq=True), 'a=0&a=1') + self.assertEqual(urlencode({'a': gen()}, doseq=False), 'a=%5B%270%27%2C+%271%27%5D') + class Base36IntTests(SimpleTestCase): def test_roundtrip(self): -- cgit v1.3