From 3bbaf84d6533fb61ac0038f2bbe52ee0d7b4fd10 Mon Sep 17 00:00:00 2001 From: Michael Tänzer Date: Sun, 7 Jun 2015 02:05:36 +0200 Subject: Fixed #18247 -- Added cast to NUMERIC for Decimals on sqlite On sqlite the SUM() of a decimal column doesn't have a NUMERIC type so when comparing it to a string literal (which a Decimal gets converted to in Django) it is not compared as expected. --- tests/aggregation_regress/tests.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'tests') diff --git a/tests/aggregation_regress/tests.py b/tests/aggregation_regress/tests.py index cb469363a0..1e680dbdd9 100644 --- a/tests/aggregation_regress/tests.py +++ b/tests/aggregation_regress/tests.py @@ -349,6 +349,20 @@ class AggregationTests(TestCase): {'c__max': 3} ) + def test_decimal_aggregate_annotation_filter(self): + """ + Filtering on an aggregate annotation with Decimal values should work. + Requires special handling on SQLite (#18247). + """ + self.assertEqual( + len(Author.objects.annotate(sum=Sum('book_contact_set__price')).filter(sum__gt=Decimal(40))), + 1 + ) + self.assertEqual( + len(Author.objects.annotate(sum=Sum('book_contact_set__price')).filter(sum__lte=Decimal(40))), + 4 + ) + def test_field_error(self): # Bad field requests in aggregates are caught and reported self.assertRaises( -- cgit v1.3