From 10d82c85aa5f8bd6adff0db49798dd368455cdcf Mon Sep 17 00:00:00 2001 From: Prabakaran Kumaresshan Date: Fri, 19 Oct 2018 12:26:33 +0530 Subject: Fixed #29831 -- Added validation for makemigrations --name. --- tests/migrations/test_commands.py | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'tests') diff --git a/tests/migrations/test_commands.py b/tests/migrations/test_commands.py index 33b85578af..816abea65a 100644 --- a/tests/migrations/test_commands.py +++ b/tests/migrations/test_commands.py @@ -1352,6 +1352,11 @@ class MakeMigrationsTests(MigrationTestBase): self.assertIn("dependencies=[\n('migrations','0001_%s'),\n]" % migration_name_0001, content) self.assertIn("operations=[\n]", content) + def test_makemigrations_with_invalid_custom_name(self): + msg = 'The migration name must be a valid Python identifier.' + with self.assertRaisesMessage(CommandError, msg): + call_command('makemigrations', 'migrations', '--name', 'invalid name', '--empty') + def test_makemigrations_check(self): """ makemigrations --check should exit with a non-zero status when -- cgit v1.3