From 0cfca0f2ccc2050de9de65a28d241d8cafcfe666 Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Thu, 2 Aug 2018 21:56:26 -0400 Subject: [2.1.x] Fixed #29627 -- Fixed QueryDict.urlencode() crash with non-string values. Regression in 7d96f0c49ab750799860e42716d7105e11de44de. Backport of d8e2be459f97f1773c7edf7d37de180139146176 from master --- tests/httpwrappers/tests.py | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'tests') diff --git a/tests/httpwrappers/tests.py b/tests/httpwrappers/tests.py index 24260ae610..01ce20f93d 100644 --- a/tests/httpwrappers/tests.py +++ b/tests/httpwrappers/tests.py @@ -114,6 +114,13 @@ class QueryDictTests(SimpleTestCase): self.assertEqual(q.urlencode(), 'next=%2Ft%C3%ABst%26key%2F') self.assertEqual(q.urlencode(safe='/'), 'next=/t%C3%ABst%26key/') + def test_urlencode_int(self): + # Normally QueryDict doesn't contain non-string values but lazily + # written tests may make that mistake. + q = QueryDict(mutable=True) + q['a'] = 1 + self.assertEqual(q.urlencode(), 'a=1') + def test_mutable_copy(self): """A copy of a QueryDict is mutable.""" q = QueryDict().copy() -- cgit v1.3