From 0a19f8d4fc864de481eac1b76c799ffd6ced4e91 Mon Sep 17 00:00:00 2001 From: Raphael Merx Date: Fri, 30 Oct 2015 15:05:11 -0700 Subject: Fixed #25644 -- Fixed reset cookie expiry date bug. Setting a cookie with the same name as a previously deleted cookie would set its expiry date to 'Thu, 01-Jan-1970 00:00:00 GMT'. --- tests/requests/tests.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'tests') diff --git a/tests/requests/tests.py b/tests/requests/tests.py index 66fe8c92ec..180a5bca6b 100644 --- a/tests/requests/tests.py +++ b/tests/requests/tests.py @@ -208,6 +208,18 @@ class RequestsTests(SimpleTestCase): datetime_cookie = response.cookies['datetime'] self.assertEqual(datetime_cookie['max-age'], 10) + def test_create_cookie_after_deleting_cookie(self): + """ + Setting a cookie after deletion should clear the expiry date. + """ + response = HttpResponse() + response.set_cookie('c', 'old-value') + self.assertEqual(response.cookies['c']['expires'], '') + response.delete_cookie('c') + self.assertEqual(response.cookies['c']['expires'], 'Thu, 01-Jan-1970 00:00:00 GMT') + response.set_cookie('c', 'new-value') + self.assertEqual(response.cookies['c']['expires'], '') + def test_far_expiration(self): "Cookie will expire when an distant expiration time is provided" response = HttpResponse() -- cgit v1.3