From d0112cf9306834b17eb5476363cb6b3b9bfb650c Mon Sep 17 00:00:00 2001 From: Anton Samarchyan Date: Thu, 1 Dec 2016 11:05:08 -0500 Subject: Fixed #26494 -- Made Archive.extract() preserve file permissions. --- tests/utils_tests/archives/foobar.tar | Bin 10240 -> 5632 bytes tests/utils_tests/archives/foobar.tar.bz2 | Bin 238 -> 265 bytes tests/utils_tests/archives/foobar.tar.gz | Bin 249 -> 253 bytes tests/utils_tests/archives/foobar.zip | Bin 1130 -> 810 bytes tests/utils_tests/test_archive.py | 10 ++++++++++ 5 files changed, 10 insertions(+) (limited to 'tests/utils_tests') diff --git a/tests/utils_tests/archives/foobar.tar b/tests/utils_tests/archives/foobar.tar index 5418405070..44886fb33b 100644 Binary files a/tests/utils_tests/archives/foobar.tar and b/tests/utils_tests/archives/foobar.tar differ diff --git a/tests/utils_tests/archives/foobar.tar.bz2 b/tests/utils_tests/archives/foobar.tar.bz2 index 693529dcef..5a3d8a402e 100644 Binary files a/tests/utils_tests/archives/foobar.tar.bz2 and b/tests/utils_tests/archives/foobar.tar.bz2 differ diff --git a/tests/utils_tests/archives/foobar.tar.gz b/tests/utils_tests/archives/foobar.tar.gz index 5b596bd58e..8582a87139 100644 Binary files a/tests/utils_tests/archives/foobar.tar.gz and b/tests/utils_tests/archives/foobar.tar.gz differ diff --git a/tests/utils_tests/archives/foobar.zip b/tests/utils_tests/archives/foobar.zip index dc3e2fc067..b02bb3e95a 100644 Binary files a/tests/utils_tests/archives/foobar.zip and b/tests/utils_tests/archives/foobar.zip differ diff --git a/tests/utils_tests/test_archive.py b/tests/utils_tests/test_archive.py index d1dc5f2841..42f445ce9c 100644 --- a/tests/utils_tests/test_archive.py +++ b/tests/utils_tests/test_archive.py @@ -1,5 +1,7 @@ import os import shutil +import stat +import sys import tempfile import unittest @@ -42,6 +44,14 @@ class ArchiveTester(object): extract(self.archive_path, self.tmpdir) self.check_files(self.tmpdir) + @unittest.skipIf(sys.platform == 'win32', 'Python on Windows has a limited os.chmod().') + def test_extract_file_permissions(self): + """Archive.extract() preserves file permissions.""" + extract(self.archive_path, self.tmpdir) + filepath = os.path.join(self.tmpdir, 'executable') + # The file has executable permission. + self.assertTrue(os.stat(filepath).st_mode & stat.S_IXOTH) + def test_extract_function_with_leadpath(self): extract(self.archive_lead_path, self.tmpdir) self.check_files(self.tmpdir) -- cgit v1.3