From 91acfc3514280370535f1dd6bebee57760bac7b9 Mon Sep 17 00:00:00 2001 From: Baptiste Mispelon Date: Thu, 4 Nov 2021 15:31:26 +0100 Subject: Fixed #33264 -- Made test runner return non-zero error code for unexpected successes. --- tests/test_runner/test_discover_runner.py | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'tests/test_runner') diff --git a/tests/test_runner/test_discover_runner.py b/tests/test_runner/test_discover_runner.py index 0012be5a7e..7fef5652df 100644 --- a/tests/test_runner/test_discover_runner.py +++ b/tests/test_runner/test_discover_runner.py @@ -644,6 +644,24 @@ class DiscoverRunnerTests(SimpleTestCase): runner.log('log message', level) self.assertEqual(cm.output, [expected]) + def test_suite_result_with_failure(self): + cases = [ + (1, 'FailureTestCase'), + (1, 'ErrorTestCase'), + (0, 'ExpectedFailureTestCase'), + (1, 'UnexpectedSuccessTestCase'), + ] + runner = DiscoverRunner(verbosity=0) + for expected_failures, testcase in cases: + with self.subTest(testcase=testcase): + suite = runner.build_suite([ + f'test_runner_apps.failures.tests_failures.{testcase}', + ]) + with captured_stderr(): + result = runner.run_suite(suite) + failures = runner.suite_result(suite, result) + self.assertEqual(failures, expected_failures) + class DiscoverRunnerGetDatabasesTests(SimpleTestCase): runner = DiscoverRunner(verbosity=2) -- cgit v1.3