From b3cffde5559c4fa97625512d7ec41a674be26076 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Fri, 13 Apr 2018 13:18:53 -0700 Subject: Fixed #29324 -- Made Settings raise ImproperlyConfigured if SECRET_KEY is accessed and not set. --- tests/settings_tests/tests.py | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) (limited to 'tests/settings_tests') diff --git a/tests/settings_tests/tests.py b/tests/settings_tests/tests.py index 09c062c897..9187f87388 100644 --- a/tests/settings_tests/tests.py +++ b/tests/settings_tests/tests.py @@ -292,8 +292,20 @@ class SettingsTests(SimpleTestCase): def test_no_secret_key(self): settings_module = ModuleType('fake_settings_module') sys.modules['fake_settings_module'] = settings_module - msg = 'The SECRET_KEY setting must not be empty.' + msg = 'The SECRET_KEY setting must be set.' try: + settings = Settings('fake_settings_module') + with self.assertRaisesMessage(ImproperlyConfigured, msg): + settings.SECRET_KEY + finally: + del sys.modules['fake_settings_module'] + + def test_secret_key_empty_string(self): + settings_module = ModuleType('fake_settings_module') + settings_module.SECRET_KEY = '' + sys.modules['fake_settings_module'] = settings_module + try: + msg = 'The SECRET_KEY setting must not be empty.' with self.assertRaisesMessage(ImproperlyConfigured, msg): Settings('fake_settings_module') finally: -- cgit v1.3