From 3e7497a05e7f7cf0ff157d88cef18e95e3cff57b Mon Sep 17 00:00:00 2001 From: Imran Iqbal Date: Tue, 31 Oct 2017 00:03:52 +0000 Subject: Fixed #28758 -- Fixed RangeMax/MinValueValidators crash with unbound ranges. --- tests/postgres_tests/test_ranges.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'tests/postgres_tests') diff --git a/tests/postgres_tests/test_ranges.py b/tests/postgres_tests/test_ranges.py index d87ad36438..f368736384 100644 --- a/tests/postgres_tests/test_ranges.py +++ b/tests/postgres_tests/test_ranges.py @@ -408,18 +408,24 @@ class TestValidators(PostgreSQLTestCase): def test_max(self): validator = RangeMaxValueValidator(5) validator(NumericRange(0, 5)) + msg = 'Ensure that this range is completely less than or equal to 5.' with self.assertRaises(exceptions.ValidationError) as cm: validator(NumericRange(0, 10)) - self.assertEqual(cm.exception.messages[0], 'Ensure that this range is completely less than or equal to 5.') + self.assertEqual(cm.exception.messages[0], msg) self.assertEqual(cm.exception.code, 'max_value') + with self.assertRaisesMessage(exceptions.ValidationError, msg): + validator(NumericRange(0, None)) # an unbound range def test_min(self): validator = RangeMinValueValidator(5) validator(NumericRange(10, 15)) + msg = 'Ensure that this range is completely greater than or equal to 5.' with self.assertRaises(exceptions.ValidationError) as cm: validator(NumericRange(0, 10)) - self.assertEqual(cm.exception.messages[0], 'Ensure that this range is completely greater than or equal to 5.') + self.assertEqual(cm.exception.messages[0], msg) self.assertEqual(cm.exception.code, 'min_value') + with self.assertRaisesMessage(exceptions.ValidationError, msg): + validator(NumericRange(None, 10)) # an unbound range class TestFormField(PostgreSQLTestCase): -- cgit v1.3