From 847f46e9bf88964484c8b76a10af753ea1018311 Mon Sep 17 00:00:00 2001 From: Nick Pope Date: Tue, 22 Feb 2022 09:29:38 +0000 Subject: Removed redundant QuerySet.all() calls in docs and tests. Most QuerySet methods are mapped onto the Manager and, in general, it isn't necessary to call .all() on the manager. --- tests/multiple_database/tests.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'tests/multiple_database') diff --git a/tests/multiple_database/tests.py b/tests/multiple_database/tests.py index 2dc894b858..7a9ff4da4e 100644 --- a/tests/multiple_database/tests.py +++ b/tests/multiple_database/tests.py @@ -219,11 +219,11 @@ class QueryTestCase(TestCase): # Retrieve related object by descriptor. Related objects should be # database-bound. self.assertEqual( - list(dive.authors.all().values_list("name", flat=True)), ["Mark Pilgrim"] + list(dive.authors.values_list("name", flat=True)), ["Mark Pilgrim"] ) self.assertEqual( - list(mark.book_set.all().values_list("title", flat=True)), + list(mark.book_set.values_list("title", flat=True)), ["Dive into Python"], ) @@ -985,7 +985,7 @@ class QueryTestCase(TestCase): # Retrieve related object by descriptor. Related objects should be # database-bound. self.assertEqual( - list(dive.reviews.all().values_list("source", flat=True)), ["Python Weekly"] + list(dive.reviews.values_list("source", flat=True)), ["Python Weekly"] ) def test_generic_key_reverse_operations(self): @@ -2415,7 +2415,7 @@ class RouteForWriteTestCase(TestCase): book.authors.add(auth) with self.assertRaises(RouterUsed) as cm: with self.override_router(): - book.authors.all().update(name="Different") + book.authors.update(name="Different") e = cm.exception self.assertEqual(e.mode, RouterUsed.WRITE) self.assertEqual(e.model, Person) @@ -2497,7 +2497,7 @@ class RouteForWriteTestCase(TestCase): book.authors.add(auth) with self.assertRaises(RouterUsed) as cm: with self.override_router(): - auth.book_set.all().update(title="Different") + auth.book_set.update(title="Different") e = cm.exception self.assertEqual(e.mode, RouterUsed.WRITE) self.assertEqual(e.model, Book) -- cgit v1.3