From ee4edb1eda2ac8f09eb298929282b44776930c89 Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Fri, 21 Mar 2014 20:44:34 -0400 Subject: Made ModelForms raise ImproperlyConfigured if the list of fields is not specified. Also applies to modelform(set)_factory and generic model views. refs #19733. --- tests/model_formsets/tests.py | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'tests/model_formsets') diff --git a/tests/model_formsets/tests.py b/tests/model_formsets/tests.py index c1e01cd6be..4c7d2a535e 100644 --- a/tests/model_formsets/tests.py +++ b/tests/model_formsets/tests.py @@ -6,6 +6,7 @@ from datetime import date from decimal import Decimal from django import forms +from django.core.exceptions import ImproperlyConfigured from django.db import models from django.forms.models import (_get_foreign_key, inlineformset_factory, modelformset_factory, BaseModelFormSet) @@ -131,6 +132,15 @@ class DeletionTests(TestCase): class ModelFormsetTest(TestCase): + def test_modelformset_factory_without_fields(self): + """ Regression for #19733 """ + message = ( + "Calling modelformset_factory without defining 'fields' or 'exclude' " + "explicitly is prohibited." + ) + with self.assertRaisesMessage(ImproperlyConfigured, message): + modelformset_factory(Author) + def test_simple_save(self): qs = Author.objects.all() AuthorFormSet = modelformset_factory(Author, fields="__all__", extra=3) -- cgit v1.3