From 21046e77734278cea871dce922220bf29aa5b7b4 Mon Sep 17 00:00:00 2001 From: Jon Dufresne Date: Sat, 27 May 2017 16:08:46 -0700 Subject: Fixed #28249 -- Removed unnecessary dict.keys() calls. iter(dict) is equivalent to iter(dict.keys()). --- tests/model_forms/tests.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'tests/model_forms') diff --git a/tests/model_forms/tests.py b/tests/model_forms/tests.py index c85eb2a6fa..6520e54d06 100644 --- a/tests/model_forms/tests.py +++ b/tests/model_forms/tests.py @@ -2783,7 +2783,7 @@ class ModelFormInheritanceTests(SimpleTestCase): model = Writer fields = '__all__' - self.assertEqual(list(ModelForm().fields.keys()), ['name', 'age']) + self.assertEqual(list(ModelForm().fields), ['name', 'age']) def test_field_removal(self): class ModelForm(forms.ModelForm): @@ -2800,13 +2800,13 @@ class ModelFormInheritanceTests(SimpleTestCase): class Form2(forms.Form): foo = forms.IntegerField() - self.assertEqual(list(ModelForm().fields.keys()), ['name']) - self.assertEqual(list(type('NewForm', (Mixin, Form), {})().fields.keys()), []) - self.assertEqual(list(type('NewForm', (Form2, Mixin, Form), {})().fields.keys()), ['foo']) - self.assertEqual(list(type('NewForm', (Mixin, ModelForm, Form), {})().fields.keys()), ['name']) - self.assertEqual(list(type('NewForm', (ModelForm, Mixin, Form), {})().fields.keys()), ['name']) - self.assertEqual(list(type('NewForm', (ModelForm, Form, Mixin), {})().fields.keys()), ['name', 'age']) - self.assertEqual(list(type('NewForm', (ModelForm, Form), {'age': None})().fields.keys()), ['name']) + self.assertEqual(list(ModelForm().fields), ['name']) + self.assertEqual(list(type('NewForm', (Mixin, Form), {})().fields), []) + self.assertEqual(list(type('NewForm', (Form2, Mixin, Form), {})().fields), ['foo']) + self.assertEqual(list(type('NewForm', (Mixin, ModelForm, Form), {})().fields), ['name']) + self.assertEqual(list(type('NewForm', (ModelForm, Mixin, Form), {})().fields), ['name']) + self.assertEqual(list(type('NewForm', (ModelForm, Form, Mixin), {})().fields), ['name', 'age']) + self.assertEqual(list(type('NewForm', (ModelForm, Form), {'age': None})().fields), ['name']) def test_field_removal_name_clashes(self): """ @@ -2974,7 +2974,7 @@ class FormFieldCallbackTests(SimpleTestCase): class InheritedForm(NewForm): pass - for name in NewForm.base_fields.keys(): + for name in NewForm.base_fields: self.assertEqual( type(InheritedForm.base_fields[name].widget), type(NewForm.base_fields[name].widget) -- cgit v1.3