From c512912463c11428e572fb409704b351b1b26dfd Mon Sep 17 00:00:00 2001 From: Nick Pope Date: Mon, 11 Dec 2017 15:35:19 +0000 Subject: Refs #23801 -- Made integer field max_length warning show correct field type. --- tests/invalid_models_tests/test_ordinary_fields.py | 29 ++++++++++++++-------- 1 file changed, 18 insertions(+), 11 deletions(-) (limited to 'tests/invalid_models_tests') diff --git a/tests/invalid_models_tests/test_ordinary_fields.py b/tests/invalid_models_tests/test_ordinary_fields.py index 184041c24d..e1c04c2d36 100644 --- a/tests/invalid_models_tests/test_ordinary_fields.py +++ b/tests/invalid_models_tests/test_ordinary_fields.py @@ -617,17 +617,24 @@ class IntegerFieldTests(SimpleTestCase): def test_max_length_warning(self): class Model(models.Model): - value = models.IntegerField(max_length=2) - - field = Model._meta.get_field('value') - self.assertEqual(field.check(), [ - DjangoWarning( - "'max_length' is ignored when used with IntegerField", - hint="Remove 'max_length' from field", - obj=field, - id='fields.W122', - ) - ]) + integer = models.IntegerField(max_length=2) + biginteger = models.BigIntegerField(max_length=2) + smallinteger = models.SmallIntegerField(max_length=2) + positiveinteger = models.PositiveIntegerField(max_length=2) + positivesmallinteger = models.PositiveSmallIntegerField(max_length=2) + + for field in Model._meta.get_fields(): + if field.auto_created: + continue + with self.subTest(name=field.name): + self.assertEqual(field.check(), [ + DjangoWarning( + "'max_length' is ignored when used with %s." % field.__class__.__name__, + hint="Remove 'max_length' from field", + obj=field, + id='fields.W122', + ) + ]) @isolate_apps('invalid_models_tests') -- cgit v1.3