From 9d40b6bbf44d0de4d446dde5b9b51cadb60a24a3 Mon Sep 17 00:00:00 2001 From: Zeynel Özdemir Date: Sun, 15 Dec 2019 00:13:33 +0100 Subject: Fixed #31076 -- Fixed dbshell crash on Windows with Python < 3.8. subprocess.run()'s args parameter accepts path-like objects on Windows since Python 3.8. --- tests/dbshell/test_sqlite.py | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 tests/dbshell/test_sqlite.py (limited to 'tests/dbshell/test_sqlite.py') diff --git a/tests/dbshell/test_sqlite.py b/tests/dbshell/test_sqlite.py new file mode 100644 index 0000000000..46d09895c8 --- /dev/null +++ b/tests/dbshell/test_sqlite.py @@ -0,0 +1,31 @@ +from pathlib import Path +from subprocess import CompletedProcess +from unittest import mock, skipUnless + +from django.db import connection +from django.db.backends.sqlite3.client import DatabaseClient +from django.test import SimpleTestCase + + +@skipUnless(connection.vendor == 'sqlite', 'SQLite tests.') +class SqliteDbshellCommandTestCase(SimpleTestCase): + def _run_dbshell(self): + """Run runshell command and capture its arguments.""" + def _mock_subprocess_run(*args, **kwargs): + self.subprocess_args = list(*args) + return CompletedProcess(self.subprocess_args, 0) + + client = DatabaseClient(connection) + with mock.patch('subprocess.run', new=_mock_subprocess_run): + client.runshell() + return self.subprocess_args + + def test_path_name(self): + with mock.patch.dict( + connection.settings_dict, + {'NAME': Path('test.db.sqlite3')}, + ): + self.assertEqual( + self._run_dbshell(), + ['sqlite3', 'test.db.sqlite3'], + ) -- cgit v1.3