From 567cfc1601a5f475eea12bc5de53b849fa5dadea Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Tue, 28 Jun 2016 11:21:26 -0400 Subject: [1.10.x] Replaced use of TestCase.fail() with assertRaises(). Also removed try/except/fail antipattern that hides exceptions. Backport of c9ae09addffb839403312131d4251e9d8b454508 from master --- tests/check_framework/tests.py | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) (limited to 'tests/check_framework/tests.py') diff --git a/tests/check_framework/tests.py b/tests/check_framework/tests.py index 6e4115140a..e57e824ecb 100644 --- a/tests/check_framework/tests.py +++ b/tests/check_framework/tests.py @@ -224,10 +224,7 @@ class SilencingCheckTests(SimpleTestCase): def test_silenced_error(self): out = StringIO() err = StringIO() - try: - call_command('check', stdout=out, stderr=err) - except CommandError: - self.fail("The mycheck.E001 check should be silenced.") + call_command('check', stdout=out, stderr=err) self.assertEqual(out.getvalue(), 'System check identified no issues (1 silenced).\n') self.assertEqual(err.getvalue(), '') @@ -236,11 +233,7 @@ class SilencingCheckTests(SimpleTestCase): def test_silenced_warning(self): out = StringIO() err = StringIO() - try: - call_command('check', stdout=out, stderr=err) - except CommandError: - self.fail("The mycheck.E001 check should be silenced.") - + call_command('check', stdout=out, stderr=err) self.assertEqual(out.getvalue(), 'System check identified no issues (1 silenced).\n') self.assertEqual(err.getvalue(), '') -- cgit v1.3