From f386454d1302b66d0eb331ed0ae9e4811e2f3a15 Mon Sep 17 00:00:00 2001 From: Guillermo Bonvehí Date: Sat, 20 Jun 2020 04:33:24 -0300 Subject: Fixed #31728 -- Fixed cache culling when no key is found for deletion. DatabaseCache._cull implementation could fail if no key was found to perform a deletion in the table. This prevented the new cache key/value from being correctly added. --- tests/cache/tests.py | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'tests/cache') diff --git a/tests/cache/tests.py b/tests/cache/tests.py index d404475e16..dc4a221060 100644 --- a/tests/cache/tests.py +++ b/tests/cache/tests.py @@ -621,6 +621,20 @@ class BaseCacheTests: def test_zero_cull(self): self._perform_cull_test('zero_cull', 50, 19) + def test_cull_delete_when_store_empty(self): + try: + cull_cache = caches['cull'] + except InvalidCacheBackendError: + self.skipTest("Culling isn't implemented.") + old_max_entries = cull_cache._max_entries + # Force _cull to delete on first cached record. + cull_cache._max_entries = -1 + try: + cull_cache.set('force_cull_delete', 'value', 1000) + self.assertIs(cull_cache.has_key('force_cull_delete'), True) + finally: + cull_cache._max_entries = old_max_entries + def _perform_invalid_key_test(self, key, expected_warning): """ All the builtin backends should warn (except memcached that should -- cgit v1.3