From 0d9ff873d9f93efbba875efbf582db88bb0e30ce Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Thu, 10 Nov 2016 06:30:38 -0500 Subject: Fixed #27467 -- Made UserAttributeSimilarityValidator max_similarity=0/1 work as documented. Thanks goblinJoel for the report and feedback. --- tests/auth_tests/test_validators.py | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) (limited to 'tests/auth_tests') diff --git a/tests/auth_tests/test_validators.py b/tests/auth_tests/test_validators.py index 97cf396b1a..e074716f46 100644 --- a/tests/auth_tests/test_validators.py +++ b/tests/auth_tests/test_validators.py @@ -124,7 +124,22 @@ class UserAttributeSimilarityValidatorTest(TestCase): max_similarity=0.3, ).validate('testclient', user=user) self.assertEqual(cm.exception.messages, [expected_error % "first name"]) - + # max_similarity=1 doesn't allow passwords that are identical to the + # attribute's value. + with self.assertRaises(ValidationError) as cm: + UserAttributeSimilarityValidator( + user_attributes=['first_name'], + max_similarity=1, + ).validate(user.first_name, user=user) + self.assertEqual(cm.exception.messages, [expected_error % "first name"]) + # max_similarity=0 rejects all passwords. + with self.assertRaises(ValidationError) as cm: + UserAttributeSimilarityValidator( + user_attributes=['first_name'], + max_similarity=0, + ).validate('XXX', user=user) + self.assertEqual(cm.exception.messages, [expected_error % "first name"]) + # Passes validation. self.assertIsNone( UserAttributeSimilarityValidator(user_attributes=['first_name']).validate('testclient', user=user) ) -- cgit v1.3