From c7cc4cfb9ebef17930db4a92cd0632a536a4ff7a Mon Sep 17 00:00:00 2001 From: Claude Paroz Date: Sat, 17 Mar 2012 22:31:03 +0000 Subject: Fixed #16138 -- Made FormMixin get_initial return a copy of the 'initial' class variable. Thanks hanson2010, wilfred@potatolondon.com and agriffis for their work on the patch. git-svn-id: http://code.djangoproject.com/svn/django/trunk@17765 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- docs/ref/class-based-views.txt | 7 ++++++- docs/releases/1.4.txt | 9 +++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) (limited to 'docs') diff --git a/docs/ref/class-based-views.txt b/docs/ref/class-based-views.txt index e1ff28977d..5223aee018 100644 --- a/docs/ref/class-based-views.txt +++ b/docs/ref/class-based-views.txt @@ -431,9 +431,14 @@ FormMixin .. method:: get_initial() - Retrieve initial data for the form. By default, returns + Retrieve initial data for the form. By default, returns a copy of :attr:`.initial`. + .. admonition:: Changed in 1.4 + + In Django 1.3, this method was returning the :attr:`initial` class + variable itself. + .. method:: get_form_class() Retrieve the form class to instantiate. By default diff --git a/docs/releases/1.4.txt b/docs/releases/1.4.txt index d82ca03d28..211d1362c8 100644 --- a/docs/releases/1.4.txt +++ b/docs/releases/1.4.txt @@ -1107,6 +1107,15 @@ passed to the markdown filter, both the ``safe_mode=True`` and Python-Markdown library less than 2.1, a warning is issued that the output is insecure. +FormMixin get_initial returns an instance-specific dictionary +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +In Django 1.3, the ``get_initial`` method of the +:class:`django.views.generic.edit.FormMixin` class was returning the +class ``initial`` dictionary. This has been fixed to return a copy of this +dictionary, so form instances can modify their initial data without messing +with the class variable. + Features deprecated in 1.4 ========================== -- cgit v1.3