From 9c30d48b45cfe694233a9e636bb516bdd9200da9 Mon Sep 17 00:00:00 2001 From: Aymeric Augustin Date: Sat, 19 Nov 2011 23:27:20 +0000 Subject: Fixed #17263 -- Added a warning when a naive datetime reaches the database layer while time zone support is enabled. After this commit, timezones.AdminTests will raise warnings because the sessions contrib app hasn't been upgraded to support time zones yet. This will be fixed in an upcoming commit. git-svn-id: http://code.djangoproject.com/svn/django/trunk@17117 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- docs/topics/i18n/timezones.txt | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) (limited to 'docs') diff --git a/docs/topics/i18n/timezones.txt b/docs/topics/i18n/timezones.txt index 18d30b941a..52c26aa038 100644 --- a/docs/topics/i18n/timezones.txt +++ b/docs/topics/i18n/timezones.txt @@ -106,9 +106,9 @@ Interpretation of naive datetime objects ---------------------------------------- When :setting:`USE_TZ` is ``True``, Django still accepts naive datetime -objects, in order to preserve backwards-compatibility. It attempts to make them -aware by interpreting them in the :ref:`default time zone -`. +objects, in order to preserve backwards-compatibility. When the database layer +receives one, it attempts to make it aware by interpreting it in the +:ref:`default time zone ` and raises a warning. Unfortunately, during DST transitions, some datetimes don't exist or are ambiguous. In such situations, pytz_ raises an exception. Other @@ -421,11 +421,22 @@ with a naive datetime that you've created in your code. So the second step is to refactor your code wherever you instanciate datetime objects to make them aware. This can be done incrementally. :mod:`django.utils.timezone` defines some handy helpers for compatibility -code: :func:`~django.utils.timezone.is_aware`, +code: :func:`~django.utils.timezone.now`, +:func:`~django.utils.timezone.is_aware`, :func:`~django.utils.timezone.is_naive`, :func:`~django.utils.timezone.make_aware`, and :func:`~django.utils.timezone.make_naive`. +Finally, in order to help you locate code that needs upgrading, Django raises +a warning when you attempt to save a naive datetime to the database. During +development, you can turn such warnings into exceptions and get a traceback +by adding to your settings file:: + + import warnings + warnings.filterwarnings( + 'error', r"DateTimeField received a naive datetime", + RuntimeWarning, r'django\.db\.models\.fields') + .. _pytz: http://pytz.sourceforge.net/ .. _these issues: http://pytz.sourceforge.net/#problems-with-localtime .. _tz database: http://en.wikipedia.org/wiki/Tz_database -- cgit v1.3