From 4c241f1b710da6419d9dca160e80b23b82db7758 Mon Sep 17 00:00:00 2001 From: Tim Graham Date: Wed, 3 Dec 2014 16:14:00 -0500 Subject: [1.4.x] Fixed is_safe_url() to handle leading whitespace. This is a security fix. Disclosure following shortly. --- docs/releases/1.4.18.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'docs') diff --git a/docs/releases/1.4.18.txt b/docs/releases/1.4.18.txt index 55256cfdf3..2da42533bd 100644 --- a/docs/releases/1.4.18.txt +++ b/docs/releases/1.4.18.txt @@ -31,6 +31,20 @@ development server now does the same. Django's development server is not recommended for production use, but matching the behavior of common production servers reduces the surface area for behavior changes during deployment. +Mitigated possible XSS attack via user-supplied redirect URLs +============================================================= + +Django relies on user input in some cases (e.g. +:func:`django.contrib.auth.views.login` and :doc:`i18n `) +to redirect the user to an "on success" URL. The security checks for these +redirects (namely ``django.util.http.is_safe_url()``) didn't strip leading +whitespace on the tested URL and as such considered URLs like +``\njavascript:...`` safe. If a developer relied on ``is_safe_url()`` to +provide safe redirect targets and put such a URL into a link, they could suffer +from a XSS attack. This bug doesn't affect Django currently, since we only put +this URL into the ``Location`` response header and browsers seem to ignore +JavaScript there. + Bugfixes ======== -- cgit v1.3