From 3daa9d60be6672841ceed5bb812b6fb25950dc16 Mon Sep 17 00:00:00 2001 From: Niclas Olofsson Date: Thu, 4 Dec 2014 21:47:48 +0100 Subject: Fixed #10414 -- Made select_related() fail on invalid field names. --- docs/releases/1.8.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'docs') diff --git a/docs/releases/1.8.txt b/docs/releases/1.8.txt index 7f8005088a..f1960304c4 100644 --- a/docs/releases/1.8.txt +++ b/docs/releases/1.8.txt @@ -681,6 +681,24 @@ lookups:: ... ValueError: Cannot query "": Must be "Author" instance. +``select_related()`` now checks given fields +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +``select_related()`` now validates that the given fields actually exist. +Previously, nonexistent fields were silently ignored. Now, an error is raised:: + + >>> book = Book.objects.select_related('nonexistent_field') + Traceback (most recent call last): + ... + FieldError: Invalid field name(s) given in select_related: 'nonexistent_field' + +The validation also makes sure that the given field is relational:: + + >>> book = Book.objects.select_related('name') + Traceback (most recent call last): + ... + FieldError: Non-relational field given in select_related: 'name' + Default ``EmailField.max_length`` increased to 254 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -- cgit v1.3