From 65b380e74ab79ee011f7556e342dd4d656b018a5 Mon Sep 17 00:00:00 2001 From: Honza Král Date: Sun, 21 Nov 2010 17:27:01 +0000 Subject: Fixed #11418 -- formset.cleaned_data no longer raises AttributeError when is_valid is True. Thanks mlavin! This also introduces a slightly backwards-incompatible change in FormSet's behavior, see the release docs for details. git-svn-id: http://code.djangoproject.com/svn/django/trunk@14667 bcc190cf-cafb-0310-a4f2-bffc1f526a37 --- docs/topics/forms/formsets.txt | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) (limited to 'docs/topics/forms') diff --git a/docs/topics/forms/formsets.txt b/docs/topics/forms/formsets.txt index e7b09dc409..fae76c7a2e 100644 --- a/docs/topics/forms/formsets.txt +++ b/docs/topics/forms/formsets.txt @@ -100,7 +100,12 @@ an ``is_valid`` method on the formset to provide a convenient way to validate all forms in the formset:: >>> ArticleFormSet = formset_factory(ArticleForm) - >>> formset = ArticleFormSet({}) + >>> data = { + ... 'form-TOTAL_FORMS': u'1', + ... 'form-INITIAL_FORMS': u'0', + ... 'form-MAX_NUM_FORMS': u'', + ... } + >>> formset = ArticleFormSet(data) >>> formset.is_valid() True @@ -113,7 +118,7 @@ provide an invalid article:: ... 'form-INITIAL_FORMS': u'0', ... 'form-MAX_NUM_FORMS': u'', ... 'form-0-title': u'Test', - ... 'form-0-pub_date': u'16 June 1904', + ... 'form-0-pub_date': u'1904-06-16', ... 'form-1-title': u'Test', ... 'form-1-pub_date': u'', # <-- this date is missing but required ... } @@ -208,9 +213,9 @@ is where you define your own validation that works at the formset level:: ... 'form-INITIAL_FORMS': u'0', ... 'form-MAX_NUM_FORMS': u'', ... 'form-0-title': u'Test', - ... 'form-0-pub_date': u'16 June 1904', + ... 'form-0-pub_date': u'1904-06-16', ... 'form-1-title': u'Test', - ... 'form-1-pub_date': u'23 June 1912', + ... 'form-1-pub_date': u'1912-06-23', ... } >>> formset = ArticleFormSet(data) >>> formset.is_valid() -- cgit v1.3