From 2ea3fb3e6386c43f124b542e92b817dbc227c76b Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Sun, 5 Jan 2020 10:04:51 +0000 Subject: Removed "Don't do that" from docs and error messages. It's slightly aggressive and doesn't explain itself. --- docs/topics/db/managers.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'docs/topics/db') diff --git a/docs/topics/db/managers.txt b/docs/topics/db/managers.txt index 1b34bea69b..473965d897 100644 --- a/docs/topics/db/managers.txt +++ b/docs/topics/db/managers.txt @@ -228,9 +228,8 @@ model. In those situations, Django has to be able to see all the objects for the model it is fetching, so that *anything* which is referred to can be retrieved. -If you override the ``get_queryset()`` method and filter out any rows, Django -will return incorrect results. Don't do that. A manager that filters results -in ``get_queryset()`` is not appropriate for use as a base manager. +Therefore, you should not override ``get_queryset()`` to filter out any rows. +If you do so, Django will return incomplete results. .. _calling-custom-queryset-methods-from-manager: -- cgit v1.3