From cd74aad90e09865ae6cd8ca0377ef0a5008d14e9 Mon Sep 17 00:00:00 2001 From: Mariusz Felisiak Date: Mon, 26 Apr 2021 09:30:40 +0200 Subject: Refs #32682 -- Renamed use_distinct variable to may_have_duplicates. QuerySet.distinct() is not the only way to avoid duplicate, it's also not preferred. --- docs/ref/contrib/admin/index.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'docs/ref') diff --git a/docs/ref/contrib/admin/index.txt b/docs/ref/contrib/admin/index.txt index 5b3493c858..8da7a72f10 100644 --- a/docs/ref/contrib/admin/index.txt +++ b/docs/ref/contrib/admin/index.txt @@ -1576,14 +1576,16 @@ templates used by the :class:`ModelAdmin` views: search_fields = ('name',) def get_search_results(self, request, queryset, search_term): - queryset, use_distinct = super().get_search_results(request, queryset, search_term) + queryset, may_have_duplicates = super().get_search_results( + request, queryset, search_term, + ) try: search_term_as_int = int(search_term) except ValueError: pass else: queryset |= self.model.objects.filter(age=search_term_as_int) - return queryset, use_distinct + return queryset, may_have_duplicates This implementation is more efficient than ``search_fields = ('name', '=age')`` which results in a string comparison for the numeric -- cgit v1.3