From 847f46e9bf88964484c8b76a10af753ea1018311 Mon Sep 17 00:00:00 2001 From: Nick Pope Date: Tue, 22 Feb 2022 09:29:38 +0000 Subject: Removed redundant QuerySet.all() calls in docs and tests. Most QuerySet methods are mapped onto the Manager and, in general, it isn't necessary to call .all() on the manager. --- docs/ref/models/expressions.txt | 2 +- docs/ref/models/querysets.txt | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'docs/ref') diff --git a/docs/ref/models/expressions.txt b/docs/ref/models/expressions.txt index 208b810048..60c4c87dcd 100644 --- a/docs/ref/models/expressions.txt +++ b/docs/ref/models/expressions.txt @@ -156,7 +156,7 @@ the field value on multiple objects - which could be very much faster than pulling them all into Python from the database, looping over them, incrementing the field value of each one, and saving each one back to the database:: - Reporter.objects.all().update(stories_filed=F('stories_filed') + 1) + Reporter.objects.update(stories_filed=F('stories_filed') + 1) ``F()`` therefore can offer performance advantages by: diff --git a/docs/ref/models/querysets.txt b/docs/ref/models/querysets.txt index 25252b9cec..44950ecf52 100644 --- a/docs/ref/models/querysets.txt +++ b/docs/ref/models/querysets.txt @@ -1110,7 +1110,7 @@ item in the Pizza ``QuerySet``. We can reduce to just two queries using ``prefetch_related``: - >>> Pizza.objects.all().prefetch_related('toppings') + >>> Pizza.objects.prefetch_related('toppings') This implies a ``self.toppings.all()`` for each ``Pizza``; now each time ``self.toppings.all()`` is called, instead of having to go to the database for @@ -1648,7 +1648,7 @@ one, doing so will result in an error. # Two equivalent QuerySets: CommonlyUsedModel.objects.all() - ManagedModel.objects.all().defer('f2') + ManagedModel.objects.defer('f2') If many fields need to be duplicated in the unmanaged model, it may be best to create an abstract model with the shared fields and then have the @@ -3771,7 +3771,7 @@ as the string based lookups passed to , , ]> # This will only execute two queries regardless of the number of Question # and Choice objects. - >>> Question.objects.prefetch_related(Prefetch('choice_set')).all() + >>> Question.objects.prefetch_related(Prefetch('choice_set')) ]> The ``queryset`` argument supplies a base ``QuerySet`` for the given lookup. -- cgit v1.3