From fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa Mon Sep 17 00:00:00 2001 From: mgaligniana Date: Wed, 23 Feb 2022 14:16:36 +0100 Subject: Fixed #28889 -- Prevented double submission of admin forms. Added a JavaScript confirm() to catch double-submissions, when the change form has already been submitted. Thanks to Adam Johnson, Claude Paroz, Keryn Knight, and Thibaud Colas for review. --- django/contrib/admin/static/admin/js/change_form.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'django') diff --git a/django/contrib/admin/static/admin/js/change_form.js b/django/contrib/admin/static/admin/js/change_form.js index 96a4c62ef4..0ba16efef9 100644 --- a/django/contrib/admin/static/admin/js/change_form.js +++ b/django/contrib/admin/static/admin/js/change_form.js @@ -1,9 +1,23 @@ +/*global gettext*/ 'use strict'; { const inputTags = ['BUTTON', 'INPUT', 'SELECT', 'TEXTAREA']; const modelName = document.getElementById('django-admin-form-add-constants').dataset.modelName; + let submitted = false; + if (modelName) { const form = document.getElementById(modelName + '_form'); + + form.addEventListener('submit', (event) => { + event.preventDefault(); + if (submitted) { + const answer = window.confirm(gettext('You have already submitted this form. Are you sure you want to submit it again?')); + if (!answer) {return;} + }; + event.target.submit(); + submitted = true; + }); + for (const element of form.elements) { // HTMLElement.offsetParent returns null when the element is not // rendered. -- cgit v1.3